From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8DCC04AAF for ; Mon, 20 May 2019 08:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FD3720656 for ; Mon, 20 May 2019 08:09:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="I2Lnt/Wt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730045AbfETIJo (ORCPT ); Mon, 20 May 2019 04:09:44 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36364 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbfETIJn (ORCPT ); Mon, 20 May 2019 04:09:43 -0400 Received: by mail-ed1-f67.google.com with SMTP id a8so22502595edx.3 for ; Mon, 20 May 2019 01:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hKt31xD+Dl8MzM54WFXgU95OQA9AwS6wGbeoPpSKfXE=; b=I2Lnt/WtkJjDLrDgWSYRJHdM95JskcT/jxH9QckQMcj/7PmrJgwgQz6Q6ftoKRwTZ9 9vCkHGOEX5MxLnlEtV98FPcLqUiMFStugzKSpO0A48EXDefeXgWbIHhMTwzBSzmXikZ5 CPJXahNcXca0FGjVF22eGZbd6XPVxBMapmwYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hKt31xD+Dl8MzM54WFXgU95OQA9AwS6wGbeoPpSKfXE=; b=ErlZSsAI11nltbzmvNNw2uRrRVMx3Pa2UgfQWuE1walc+ayjc+1Df6edgqXSyDUb8N BksNV/mjTkywScFshWLAQQ/Be9l1wyQcrVlZzSs6cdodCJkCFhbeTvSCANguKqJDybog AhhszIYQ0hd0tM/DPDw79+emkj3cIVPcS+BNAxnP6qp8pIIwLBQ695s28ZC2iNlrLt06 Iib2uZzAPcJ0Fm9prFDuREW+XLmORxo5bF4AoNYz7z/rKD9Sc68JM9PFmUZ5FPfP9CPd 7YYHF5A0xpp5Q3JXXBvikhdEC3isEFn3NkERl3L9KsOj87Hs0Zw0VviXoUAxGSnYUnFC LZEQ== X-Gm-Message-State: APjAAAXU1TaB8kk4/UNaOxd4iHmQTdQyEcMSjtHYLPZE5gVMUvFACeUr I2C68dXIViN6HMt6RgyNcNMXJw== X-Google-Smtp-Source: APXvYqyzT9sszHOtK0V/iwAwNW8LGsXi2uW7QI5DTUVDOy96+wSa9nUb5iDqOpm++yl3P0LW/Icifw== X-Received: by 2002:aa7:c4d2:: with SMTP id p18mr73940804edr.232.1558339782382; Mon, 20 May 2019 01:09:42 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id x22sm5441295edd.59.2019.05.20.01.09.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 01:09:41 -0700 (PDT) Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 To: Douglas Anderson , Ulf Hansson , Kalle Valo , Adrian Hunter Cc: linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , brcm80211-dev-list.pdl@broadcom.com, Franky Lin , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Hante Meuleman , Naveen Gupta , brcm80211-dev-list@cypress.com, YueHaibing , "David S. Miller" References: <20190517225420.176893-1-dianders@chromium.org> <20190517225420.176893-2-dianders@chromium.org> From: Arend Van Spriel Message-ID: Date: Mon, 20 May 2019 10:09:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190517225420.176893-2-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/18/2019 12:54 AM, Douglas Anderson wrote: > In commit 29f6589140a1 ("brcmfmac: disable command decode in > sdio_aos") we disabled something called "command decode in sdio_aos" > for a whole bunch of Broadcom SDIO WiFi parts. > > After that patch landed I find that my kernel log on > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 > > This seems to happen every time the Broadcom WiFi transitions out of > sleep mode. Reverting the part of the commit that affects the WiFi on > my boards fixes the problem for me, so that's what this patch does. This sounds very similar to the issue we had during integration of wifi on rk3288 chromebooks years ago. > Note that, in general, the justification in the original commit seemed > a little weak. It looked like someone was testing on a SD card > controller that would sometimes die if there were CRC errors on the > bus. This used to happen back in early days of dw_mmc (the controller > on my boards), but we fixed it. Disabling a feature on all boards > just because one SD card controller is broken seems bad. ...so > instead of just this patch possibly the right thing to do is to fully > revert the original commit. I am leaning towards a full revert, but let's wait for more background info. Regards, Arend