From: Ryan Hsu <ryanhsu@qti.qualcomm.com>
To: Gabriel Craciunescu <nix.or.die@gmail.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com>,
"joe@perches.com" <joe@perches.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
Date: Wed, 19 Jul 2017 18:41:27 +0000 [thread overview]
Message-ID: <e41a39fd-87a1-7fc7-158d-cb298e46a754@qca.qualcomm.com> (raw)
In-Reply-To: <20170719182454.11267-1-crazy@frugalware.org>
On 07/19/2017 11:24 AM, Gabriel Craciunescu wrote:
To make it consistent, maybe rename the patch title starting with ath10k:
> From: Gabriel Craciunescu <nix.or.die@gmail.com>
>
> Each time we get disconencted from AP we get flooded with messages like:
>
> ...
> ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
> <until ratelimit kicks in>
> ath10k_warn: 155 callbacks suppressed
> ...
>
> Use ath10k_dbg() here too.
You don't need an indentation on every line of the commit.
> Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wirel=
ess/ath/ath10k/htt_rx.c
> index 398dda978d6e..75d9b59b7e63 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath1=
0k *ar,
> */
> =20
> if (!rx_status->freq) {
> - ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(=
s)!\n");
> return false;
> }
> =20
--=20
Ryan Hsu
next prev parent reply other threads:[~2017-07-19 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 15:37 [PATCH] ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg() Gabriel C
2017-07-19 16:26 ` Joe Perches
2017-07-19 18:12 ` Gabriel C
2017-07-19 18:24 ` Gabriel Craciunescu
2017-07-19 18:41 ` Ryan Hsu [this message]
2017-07-19 19:19 ` [PATCH v3] ath10k: ath10k_htt_rx_amsdu_allowed() " Gabriel Craciunescu
2017-08-08 11:06 ` [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e41a39fd-87a1-7fc7-158d-cb298e46a754@qca.qualcomm.com \
--to=ryanhsu@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=joe@perches.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nix.or.die@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).