From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B08AC43461 for ; Fri, 11 Sep 2020 10:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F15AC221E5 for ; Fri, 11 Sep 2020 10:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725770AbgIKKGQ (ORCPT ); Fri, 11 Sep 2020 06:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgIKKGO (ORCPT ); Fri, 11 Sep 2020 06:06:14 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77B12C061573; Fri, 11 Sep 2020 03:06:14 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kGfwZ-0029Kz-Fj; Fri, 11 Sep 2020 12:06:11 +0200 Message-ID: Subject: Re: [PATCH v2 13/24] mac80211: determine chandef from HE 6 GHz operation From: Johannes Berg To: Wen Gong Cc: linux-wireless@vger.kernel.org, Rajkumar Manoharan , Pradeep Kumar Chitrapu , linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org Date: Fri, 11 Sep 2020 12:06:09 +0200 In-Reply-To: <010101747c80076d-8dc8fdae-d89b-497f-81ac-77d2dd7d94b5-000000@us-west-2.amazonses.com> References: <20200528213443.993f108e96ca.I0086ae42d672379380d04ac5effb2f3d5135731b@changeid> <20200528213443.25687d2695bc.I3f9747c1147480f65445f13eda5c4a5ed4e86757@changeid> <010101747c80076d-8dc8fdae-d89b-497f-81ac-77d2dd7d94b5-000000@us-west-2.amazonses.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-09-11 at 09:29 +0000, Wen Gong wrote: > On 2020-05-29 03:34, Johannes Berg wrote: > > From: Johannes Berg > > > > Support connecting to HE 6 GHz APs and mesh networks on 6 GHz, > > where the HT/VHT information is missing but instead the HE 6 GHz > > band capability is present, and the 6 GHz Operation information > > field is used to encode the channel configuration instead of the > > HT/VHT operation elements. > > > > Also add some other bits needed to connect to 6 GHz networks. > > > > Link: > > https://lore.kernel.org/r/1589399105-25472-10-git-send-email-rmanohar@codeaurora.org > > Co-developed-by: Rajkumar Manoharan > > Signed-off-by: Rajkumar Manoharan > > Signed-off-by: Johannes Berg > > --- > > net/mac80211/ieee80211_i.h | 3 ++ > > net/mac80211/mesh.c | 1 + > > net/mac80211/mlme.c | 69 +++++++++++++++++------- > > net/mac80211/util.c | 106 +++++++++++++++++++++++++++++++++++++ > > 4 files changed, 160 insertions(+), 19 deletions(-) > > > [...] > > @@ -4838,21 +4860,23 @@ static int ieee80211_prep_channel(struct > > ieee80211_sub_if_data *sdata, > > IEEE80211_STA_DISABLE_160MHZ); > > > > /* disable HT/VHT/HE if we don't support them */ > > - if (!sband->ht_cap.ht_supported) { > > + if (!sband->ht_cap.ht_supported && !is_6ghz) { > > ifmgd->flags |= IEEE80211_STA_DISABLE_HT; > > ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; > > ifmgd->flags |= IEEE80211_STA_DISABLE_HE; > > } > > > > - if (!sband->vht_cap.vht_supported) > > + if (!sband->vht_cap.vht_supported && !is_6ghz) { > > ifmgd->flags |= IEEE80211_STA_DISABLE_VHT; > > + ifmgd->flags |= IEEE80211_STA_DISABLE_HE; > > + } > when connec to NL80211_BAND_2GHZ, it does not support vht, then it > failed for HE and connected with HT mode. > I tesed with below change, it fix the issue, it connected with HE mode > for NL80211_BAND_2GHZ with an HE mode 11AX AP. Hmm. Yeah, that seems reasonable. I wonder why/how we never saw this, hm. Can you send a real patch? johannes