linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Chris Chiu <chris.chiu@canonical.com>,
	kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rtl8xxxu: Use lower tx rates for the ack packet
Date: Fri, 1 Oct 2021 01:37:33 -0400	[thread overview]
Message-ID: <e64de376-f765-fc55-0e82-84e269c4dc43@gmail.com> (raw)
In-Reply-To: <20211001040044.1028708-1-chris.chiu@canonical.com>

On 10/1/21 12:00 AM, Chris Chiu wrote:
> According to the Realtek propritary driver and the rtw88 driver, the
> tx rates of the ack (includes block ack) are initialized with lower
> tx rates (no HT rates) which is set by the RRSR register value. In
> real cases, ack rate higher than current tx rate could lead to
> difficulty for the receiving end to receive management/control frames.
> The retransmission rate would be higher then expected when the driver
> is acting as receiver and the RSSI is not good.
> 
> Cross out higer rates for ack packet before implementing dynamic rrsr
> configuration like the commit 4830872685f8 ("rtw88: add dynamic rrsr
> configuration").
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
> 
> Changelog:
>   v2:
>    - Specify the dynamic rrsr commit for reference
>    - Remove the unintentional twice reading of REG_RESPONSE_RATE_SET
> 
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 +++++-
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 2 ++
>  2 files changed, 7 insertions(+), 1 deletion(-)

Acked-by: Jes Sorensen <Jes.Sorensen@gmail.com>

  reply	other threads:[~2021-10-01  5:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  4:00 Chris Chiu
2021-10-01  5:37 ` Jes Sorensen [this message]
2021-10-05  5:33 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e64de376-f765-fc55-0e82-84e269c4dc43@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=chris.chiu@canonical.com \
    --cc=code@reto-schneider.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v2] rtl8xxxu: Use lower tx rates for the ack packet' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).