From: Sean Anderson <sean.anderson@seco.com>
To: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>
Cc: Chi-hsien Lin <chi-hsien.lin@cypress.com>,
Franky Lin <franky.lin@broadcom.com>, Tejun Heo <tj@kernel.org>,
SHA-cyfmac-dev-list@infineon.com,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] brcmfmac: Set SDIO workqueue as WQ_HIGHPRI
Date: Tue, 17 Aug 2021 12:48:33 -0400 [thread overview]
Message-ID: <e6eb89af-b81e-b96e-70a6-c9498eb681fd@seco.com> (raw)
In-Reply-To: <20210802170904.3116223-1-sean.anderson@seco.com>
ping?
On 8/2/21 1:09 PM, Sean Anderson wrote:
> This puts tasks submitted to the SDIO workqueue at the head of the queue
> and runs them immediately. This gets higher RX throughput with the SDIO
> bus.
>
> This was originally submitted as [1]. The original author Wright Feng
> reports
>
>> throughput result with 43455(11ac) on 1 core 1.6 Ghz platform is
>> Without WQ_HIGGPRI TX/RX: 293/301 (mbps)
>> With WQ_HIGHPRI TX/RX: 293/321 (mbps)
>
> I tested this with a 43364(11bgn) on a 1 core 800 MHz platform and got
> Without WQ_HIGHPRI TX/RX: 16/19 (Mbits/sec)
> With WQ_HIGHPRI TX/RX: 24/20 (MBits/sec)
>
> [1] https://lore.kernel.org/linux-wireless/1584604406-15452-4-git-send-email-wright.feng@cypress.com/
>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index 97ee9e2e2e35..5e10176c6c7e 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -4442,7 +4442,7 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
> bus->tx_seq = SDPCM_SEQ_WRAP - 1;
>
> /* single-threaded workqueue */
> - wq = alloc_ordered_workqueue("brcmf_wq/%s", WQ_MEM_RECLAIM,
> + wq = alloc_ordered_workqueue("brcmf_wq/%s", WQ_MEM_RECLAIM | WQ_HIGHPRI,
> dev_name(&sdiodev->func1->dev));
> if (!wq) {
> brcmf_err("insufficient memory to create txworkqueue\n");
>
next prev parent reply other threads:[~2021-08-17 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 17:09 [PATCH] brcmfmac: Set SDIO workqueue as WQ_HIGHPRI Sean Anderson
2021-08-17 16:48 ` Sean Anderson [this message]
2021-08-17 17:17 ` Arend van Spriel
2021-08-17 18:21 ` Sean Anderson
2021-08-17 18:28 ` Tejun Heo
2021-08-17 21:14 ` Arend van Spriel
2021-08-18 4:53 ` Arend van Spriel
2021-08-21 16:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6eb89af-b81e-b96e-70a6-c9498eb681fd@seco.com \
--to=sean.anderson@seco.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).