Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
@ 2019-10-09  9:08 zhengbin
  2019-10-09 12:58 ` Kalle Valo
  2019-10-11  8:53 ` Kalle Valo
  0 siblings, 2 replies; 6+ messages in thread
From: zhengbin @ 2019-10-09  9:08 UTC (permalink / raw)
  To: pkshih, kvalo, linux-wireless, netdev; +Cc: zhengbin13

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
index 67305ce..0546242 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
@@ -108,7 +108,6 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
 	struct rtlwifi_firmware_header *pfwheader;
 	u8 *pfwdata;
 	u32 fwsize;
-	int err;
 	enum version_8192e version = rtlhal->version;

 	if (!rtlhal->pfirmware)
@@ -146,9 +145,7 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
 	_rtl92ee_write_fw(hw, version, pfwdata, fwsize);
 	_rtl92ee_enable_fw_download(hw, false);

-	err = _rtl92ee_fw_free_to_go(hw);
-
-	return 0;
+	return _rtl92ee_fw_free_to_go(hw);
 }

 static bool _rtl92ee_check_fw_read_last_h2c(struct ieee80211_hw *hw, u8 boxnum)
--
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
  2019-10-09  9:08 [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
@ 2019-10-09 12:58 ` Kalle Valo
  2019-10-09 13:01   ` zhengbin (A)
  2019-10-11  8:53 ` Kalle Valo
  1 sibling, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2019-10-09 12:58 UTC (permalink / raw)
  To: zhengbin; +Cc: pkshih, linux-wireless, netdev

zhengbin <zhengbin13@huawei.com> writes:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

There's no changelog, why did you resend? Document clearly the changes
so that maintainers don't need to guess what has changed:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
  2019-10-09 12:58 ` Kalle Valo
@ 2019-10-09 13:01   ` zhengbin (A)
  2019-10-09 13:05     ` Kalle Valo
  0 siblings, 1 reply; 6+ messages in thread
From: zhengbin (A) @ 2019-10-09 13:01 UTC (permalink / raw)
  To: Kalle Valo; +Cc: pkshih, linux-wireless, netdev


On 2019/10/9 20:58, Kalle Valo wrote:
> zhengbin <zhengbin13@huawei.com> writes:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> There's no changelog, why did you resend? Document clearly the changes
> so that maintainers don't need to guess what has changed:

Failed to apply:

fatal: corrupt patch at line 13
error: could not build fake ancestor
Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
The copy of the patch that failed is found in: .git/rebase-apply/patch

So I resend this. 

>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
  2019-10-09 13:01   ` zhengbin (A)
@ 2019-10-09 13:05     ` Kalle Valo
  2019-10-09 13:06       ` zhengbin (A)
  0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2019-10-09 13:05 UTC (permalink / raw)
  To: zhengbin \(A\); +Cc: pkshih, linux-wireless, netdev

"zhengbin (A)" <zhengbin13@huawei.com> writes:

> On 2019/10/9 20:58, Kalle Valo wrote:
>> zhengbin <zhengbin13@huawei.com> writes:
>>
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning:
>>> variable err set but not used [-Wunused-but-set-variable]
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> There's no changelog, why did you resend? Document clearly the changes
>> so that maintainers don't need to guess what has changed:
>
> Failed to apply:
>
> fatal: corrupt patch at line 13
> error: could not build fake ancestor
> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
> The copy of the patch that failed is found in: .git/rebase-apply/patch
>
> So I resend this. 

Ok, thanks. But next time include the changelog automatically and mark
the patch as v2. And read the documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
  2019-10-09 13:05     ` Kalle Valo
@ 2019-10-09 13:06       ` zhengbin (A)
  0 siblings, 0 replies; 6+ messages in thread
From: zhengbin (A) @ 2019-10-09 13:06 UTC (permalink / raw)
  To: Kalle Valo; +Cc: pkshih, linux-wireless, netdev


On 2019/10/9 21:05, Kalle Valo wrote:
> "zhengbin (A)" <zhengbin13@huawei.com> writes:
>
>> On 2019/10/9 20:58, Kalle Valo wrote:
>>> zhengbin <zhengbin13@huawei.com> writes:
>>>
>>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>>
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning:
>>>> variable err set but not used [-Wunused-but-set-variable]
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Signed-off-by: zhengbin <zhengbin13@huawei.com>
>>>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>>> There's no changelog, why did you resend? Document clearly the changes
>>> so that maintainers don't need to guess what has changed:
>> Failed to apply:
>>
>> fatal: corrupt patch at line 13
>> error: could not build fake ancestor
>> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> The copy of the patch that failed is found in: .git/rebase-apply/patch
>>
>> So I resend this. 
> Ok, thanks. But next time include the changelog automatically and mark
> the patch as v2. And read the documentation:
Copy that, thank your for your patience
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
  2019-10-09  9:08 [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
  2019-10-09 12:58 ` Kalle Valo
@ 2019-10-11  8:53 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-10-11  8:53 UTC (permalink / raw)
  To: zhengbin; +Cc: pkshih, linux-wireless, netdev, zhengbin13

zhengbin <zhengbin13@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

59f4567d228f rtlwifi: rtl8192ee: Remove set but not used variable 'err'

-- 
https://patchwork.kernel.org/patch/11180853/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09  9:08 [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-09 12:58 ` Kalle Valo
2019-10-09 13:01   ` zhengbin (A)
2019-10-09 13:05     ` Kalle Valo
2019-10-09 13:06       ` zhengbin (A)
2019-10-11  8:53 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox