From: Johannes Berg <johannes@sipsolutions.net>
To: James Prestwood <prestwoj@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/1] Allow MAC change on up interface
Date: Tue, 20 Aug 2019 22:06:41 +0200 [thread overview]
Message-ID: <eb4b7894434dc1e194b88f4bd1bf0b2476700a2c.camel@sipsolutions.net> (raw)
In-Reply-To: <661903fa345563615cb781a6d9608607a3db963d.camel@gmail.com> (sfid-20190820_215350_076033_9D62468D)
On Tue, 2019-08-20 at 15:53 -0400, James Prestwood wrote:
> > I thought so, but I had another thought later. It might be possible
> > to
> > set LIVE_ADDR_CHANGE, but then block it in mac80211 when the
> > interface
> > is already connected (or beaconing, or whatever, using the MAC
> > address
> > in some way - even while scanning, remain-on-channel is active, etc.)
>
> Yeah that makes sense.
>
> > I still think you'd have to bake it into the mac80211<->driver API
> > somehow, because we normally "add_interface()" with the MAC address,
> > and
> > nothing says that the driver cannot ignore the MAC address from that
> > point on. The fact that iwlwifi just copies it into every new
> > MAC_CTXT
> > command and the firmware actually accepts the update seems rather
> > accidental and therefore fragile to rely on.
>
> I havent looked into the actual drivers WRT add_interface so I'll take
> a look. But I think I see the separation now and why it may not work
> for all drivers/firmwares the way I did it.
>
> So are you thinking we need another driver method:
> "change_mac/set_mac"?
Perhaps. Let's continue that in the other sub-thread, where I replied in
more detail to Denis.
johannes
prev parent reply other threads:[~2019-08-20 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:57 [RFC 0/1] Allow MAC change on up interface James Prestwood
2019-08-15 18:57 ` [RFC 1/1] RFC: allow mac address change on up iface James Prestwood
2019-08-15 20:48 ` [RFC 0/1] Allow MAC change on up interface Jeff Johnson
2019-08-16 9:56 ` Toke Høiland-Jørgensen
2019-08-19 10:14 ` Johannes Berg
2019-08-19 15:55 ` James Prestwood
2019-08-19 20:20 ` Johannes Berg
2019-08-19 20:58 ` Denis Kenzior
2019-08-20 8:59 ` Johannes Berg
2019-08-20 15:40 ` Denis Kenzior
2019-08-20 17:53 ` Dan Williams
2019-08-20 18:21 ` Denis Kenzior
2019-08-20 18:54 ` Toke Høiland-Jørgensen
2019-08-20 19:32 ` Johannes Berg
2019-08-20 19:46 ` Denis Kenzior
2019-08-20 20:01 ` Johannes Berg
2019-08-19 21:14 ` James Prestwood
2019-08-20 6:59 ` Johannes Berg
2019-08-20 19:22 ` Denis Kenzior
2019-08-20 19:43 ` Johannes Berg
2019-08-20 19:58 ` Denis Kenzior
2019-08-20 20:15 ` Johannes Berg
2019-08-20 20:37 ` Denis Kenzior
2019-08-20 21:18 ` Dan Williams
2019-08-20 21:52 ` Denis Kenzior
2019-08-21 7:21 ` Johannes Berg
2019-08-20 19:53 ` James Prestwood
2019-08-20 20:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb4b7894434dc1e194b88f4bd1bf0b2476700a2c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).