Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/7] brcmsmac: switch source files to using SPDX license identifier
Date: Thu, 16 May 2019 22:15:41 +0200
Message-ID: <eeebea29-4237-6e49-7578-8d3b1ad7df85@broadcom.com> (raw)
In-Reply-To: <20190516200131.GA15814@kroah.com>

On 5/16/2019 10:01 PM, Greg Kroah-Hartman wrote:
> On Thu, May 16, 2019 at 09:45:19PM +0200, Arend Van Spriel wrote:
>> On 5/16/2019 7:31 PM, Greg Kroah-Hartman wrote:
>>> On Thu, May 16, 2019 at 02:04:07PM +0200, Arend van Spriel wrote:
>>>> With ISC license text in place under the LICENSES folder switch
>>>> to using the SPDX license identifier to refer to the ISC license.
>>>>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
>>>> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
>>>> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
>>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>>>> ---
>>>> Hi Thomas, Greg,
>>>>
>>>> The file drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c
>>>> did not have license information nor copyright notice and as such
>>>> it got included in commit b24413180f56 ("License cleanup: add SPDX
>>>> GPL-2.0 license identifier to files with no license"). I added you
>>>> guys as I propose to align this source file with the rest of
>>>> the driver sources and change it to ISC license and add the missing
>>>> copyright notice while at it (not sure if that warrants a separate
>>>> patch).
>>>
>>> A separate patch would be good, to make it explicit that you are
>>> changing the license of the file.
>>
>> Ok.
>>
>>> And ISC, ick, why...  :)
>>
>> Because the license text in the other driver source files is a 1:1 match
>> with the ISC license.
> 
> Oh, I am not disagreeing with that, yes, that is obviously the license
> of the files. Just complaining about that choice for Linux kernel code :)

I see.

>> Another option could be MIT license which is in the preferred folder.
>> Will have to consult our legal department about it though.
> 
> Hey, if your legal department is going to get asked this, why not just
> switch it to GPLv2?  That would make everything much simpler.

Hah. Because I already know the answer to that. ;-)

Regards,
Arend

  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 12:04 [PATCH 0/7] brcm80211: SPDX tags and Kconfig cleanup Arend van Spriel
2019-05-16 12:04 ` [PATCH 1/7] brcm80211: switch common header files to using SPDX license identifier Arend van Spriel
2019-05-16 20:57   ` Arend Van Spriel
2019-05-17 18:04     ` Arend Van Spriel
2019-05-20 16:54       ` Kalle Valo
2019-05-21  8:11         ` Arend Van Spriel
2019-05-23  9:17           ` Kalle Valo
2019-05-23 10:53             ` Arend Van Spriel
2019-05-28 12:24   ` Kalle Valo
2019-05-16 12:04 ` [PATCH 2/7] brcmutil: switch source " Arend van Spriel
2019-05-16 12:04 ` [PATCH 3/7] brcmsmac: " Arend van Spriel
2019-05-16 17:31   ` Greg Kroah-Hartman
2019-05-16 19:45     ` Arend Van Spriel
2019-05-16 20:01       ` Greg Kroah-Hartman
2019-05-16 20:15         ` Arend Van Spriel [this message]
2019-05-17 18:07           ` Rafał Miłecki
2019-05-17 18:22             ` Arend Van Spriel
2019-07-08 10:07             ` Arend Van Spriel
2019-07-08 10:41               ` Greg Kroah-Hartman
2019-05-23  9:16   ` Kalle Valo
2019-05-16 12:04 ` [PATCH 4/7] brcmsmac: switch phy " Arend van Spriel
2019-05-16 12:04 ` [PATCH 5/7] brcmfmac: switch " Arend van Spriel
2019-05-16 12:04 ` [PATCH 6/7] brcmfmac: use separate Kconfig file for brcmfmac Arend van Spriel
2019-05-16 12:04 ` [PATCH 7/7] brcm80211: select WANT_DEV_COREDUMP conditionally " Arend van Spriel

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eeebea29-4237-6e49-7578-8d3b1ad7df85@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox