From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Avinash Patil <avinashp@quantenna.com>,
sergey.matyukevich.os@quantenna.com
Subject: Re: [PATCH] nl80211: add an option to allow MFP without requiring it
Date: Mon, 14 Aug 2017 11:44:55 -0700 [thread overview]
Message-ID: <efee59e0-dd5b-41a0-64c7-66edb2c439dc@quantenna.com> (raw)
In-Reply-To: <20170814134911.20869-1-emmanuel.grumbach@intel.com>
On 08/14/2017 06:49 AM, Emmanuel Grumbach wrote:
>
> User space can now allow the kernel to associate to an AP
> that requires MFP or that doesn't have MFP enabled in the
> same NL80211_CMD_CONNECT command.
> The driver / firmware will decide whether to use it or not.
>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
No issues from quantenna driver.
Acked-by Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
[...]
> @@ -4086,10 +4090,12 @@ enum nl80211_key_type {
> * enum nl80211_mfp - Management frame protection state
> * @NL80211_MFP_NO: Management frame protection not used
> * @NL80211_MFP_REQUIRED: Management frame protection required
> + * @NL80211_MFP_OPTIONAL: Management frame is optional
Probably meant to be "Management frame _protection_ is optional"
> */
> enum nl80211_mfp {
> NL80211_MFP_NO,
> NL80211_MFP_REQUIRED,
> + NL80211_MFP_OPTIONAL,
> };
>
> enum nl80211_wpa_versions {
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 8f035d9868d1..829867132326 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -9115,6 +9115,7 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info)
> if (info->attrs[NL80211_ATTR_USE_MFP]) {
> connect.mfp = nla_get_u32(info->attrs[NL80211_ATTR_USE_MFP]);
> if (connect.mfp != NL80211_MFP_REQUIRED &&
> + connect.mfp != NL80211_MFP_OPTIONAL &&
> connect.mfp != NL80211_MFP_NO)
> return -EINVAL;
> } else {
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-08-14 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 13:49 [PATCH] nl80211: add an option to allow MFP without requiring it Emmanuel Grumbach
2017-08-14 17:14 ` Kalle Valo
2017-08-14 18:13 ` Grumbach, Emmanuel
2017-08-15 7:16 ` Kalle Valo
2017-08-15 7:49 ` Grumbach, Emmanuel
2017-08-15 8:03 ` Grumbach, Emmanuel
2017-08-14 18:44 ` Igor Mitsyanko
2017-08-14 18:44 ` Igor Mitsyanko [this message]
2017-08-14 19:22 ` Arend van Spriel
2017-08-14 20:08 ` Igor Mitsyanko
2017-08-14 20:13 ` Grumbach, Emmanuel
2017-08-14 20:36 ` Igor Mitsyanko
2017-08-15 6:12 ` Grumbach, Emmanuel
2017-08-15 8:14 ` [PATCH v2] " Emmanuel Grumbach
2017-08-15 8:28 ` [PATCH v3] " Emmanuel Grumbach
2017-08-18 12:31 ` [PATCH v4 12/19] " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efee59e0-dd5b-41a0-64c7-66edb2c439dc@quantenna.com \
--to=igor.mitsyanko.os@quantenna.com \
--cc=avinashp@quantenna.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).