From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACECBC31E5B for ; Mon, 17 Jun 2019 10:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77A7B2086A for ; Mon, 17 Jun 2019 10:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZmPOJv+u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbfFQKw4 (ORCPT ); Mon, 17 Jun 2019 06:52:56 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37815 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbfFQKw4 (ORCPT ); Mon, 17 Jun 2019 06:52:56 -0400 Received: by mail-wm1-f68.google.com with SMTP id f17so6065248wme.2 for ; Mon, 17 Jun 2019 03:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZrGsAut7uTsx4N98mpJ5emxcDiHoXMt2HeuGIHuHDuY=; b=ZmPOJv+uNeM7+bNBeQqLGswxWW9SMhfKnc014mIavxJdV79s0wjtcZT2VyUWK+UWrD Movw97H2zsJ+JBlhl315a19BTQrUa1M7tC7Gn1UzYUsnywZm6KraZ77S5sjMvTlk+U8Z LBfBBRYF8bxGvs2tbraE55QLhVFojz1qPLIU8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZrGsAut7uTsx4N98mpJ5emxcDiHoXMt2HeuGIHuHDuY=; b=kHCYaAXRJYKX/ZiA29X3bbwBhYTyDSGIQnFikLdesunzuiSgSy4c5ppLQPInniVM0h 7VZ9vwaYvvo1rarUGokjQF23jjdB8qEjBoAsAI6DU4Ij130iF06DZIaRb8FevR6juRA8 zQeMXy04sqVqZH8pI9am2itxAS67NLyKbOelIMSzxyCj3eDQi0bUCfBaMy1c+nJPgJOQ jWuPkEDQa0G3oeSJ9rx748JtNq41LbKsVIF3f4vMT1Xk71Hsa99PAd3YXO/Kg/ZbZvHj QC0IJbz3qxvy1nL+H7ZEdlfS/G7PCNWnZtmtNnAc28IEAlFS69xtn+VBbj6FREO0pgGh bC+w== X-Gm-Message-State: APjAAAUeY85AcwZvbSahBBUJ1udhN1Oy79/No5OCcSQ2ZDTrL9x32kdN CvgAFvjbti/+b+nXIDsuQ0DPQw== X-Google-Smtp-Source: APXvYqxwU5akwxSHDxkkxP8iCz4MY4SSgr81eWPc6HIAiFo2nQ2pP4CVo+hHo0NsY+yWo6H1GCq6JQ== X-Received: by 2002:a1c:96c7:: with SMTP id y190mr16834836wmd.87.1560768773522; Mon, 17 Jun 2019 03:52:53 -0700 (PDT) Received: from [10.176.68.244] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id y184sm9396231wmg.14.2019.06.17.03.52.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 03:52:52 -0700 (PDT) Subject: Re: [PATCH v4 5/5] brcmfmac: sdio: Don't tune while the card is off To: Douglas Anderson , Ulf Hansson , Kalle Valo , Adrian Hunter Cc: brcm80211-dev-list.pdl@broadcom.com, linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, linux-wireless@vger.kernel.org, Naveen Gupta , Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , netdev@vger.kernel.org, brcm80211-dev-list@cypress.com, Franky Lin , linux-kernel@vger.kernel.org, Hante Meuleman , YueHaibing , "David S. Miller" References: <20190613234153.59309-1-dianders@chromium.org> <20190613234153.59309-6-dianders@chromium.org> From: Arend Van Spriel Message-ID: Date: Mon, 17 Jun 2019 12:52:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190613234153.59309-6-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/14/2019 1:41 AM, Douglas Anderson wrote: > When Broadcom SDIO cards are idled they go to sleep and a whole > separate subsystem takes over their SDIO communication. This is the > Always-On-Subsystem (AOS) and it can't handle tuning requests. > > Specifically, as tested on rk3288-veyron-minnie (which reports having > BCM4354/1 in dmesg), if I force a retune in brcmf_sdio_kso_control() > when "on = 1" (aka we're transition from sleep to wake) by whacking: > bus->sdiodev->func1->card->host->need_retune = 1 > ...then I can often see tuning fail. In this case dw_mmc reports "All > phases bad!"). Note that I don't get 100% failure, presumably because > sometimes the card itself has already transitioned away from the AOS > itself by the time we try to wake it up. If I force retuning when "on > = 0" (AKA force retuning right before sending the command to go to > sleep) then retuning is always OK. > > NOTE: we need _both_ this patch and the patch to avoid triggering > tuning due to CRC errors in the sleep/wake transition, AKA ("brcmfmac: > sdio: Disable auto-tuning around commands expected to fail"). Though > both patches handle issues with Broadcom's AOS, the problems are > distinct: > 1. We want to defer (but not ignore) asynchronous (like > timer-requested) tuning requests till the card is awake. However, > we want to ignore CRC errors during the transition, we don't want > to queue deferred tuning request. > 2. You could imagine that the AOS could implement retuning but we > could still get errors while transitioning in and out of the AOS. > Similarly you could imagine a seamless transition into and out of > the AOS (with no CRC errors) even if the AOS couldn't handle > tuning. > > ALSO NOTE: presumably there is never a desperate need to retune in > order to wake up the card, since doing so is impossible. Luckily the > only way the card can get into sleep state is if we had a good enough > tuning to send it a sleep command, so presumably that "good enough" > tuning is enough to wake us up, at least with a few retries. The term "sleep command" is a bit confusing. There actually is a CMD14 defined in the eSD spec, but that is not what we are using (unless we program the chip to do so) here. It is simply a specific register access using CMD52. Apart from that.... Reviewed-by: Arend van Spriel > > Signed-off-by: Douglas Anderson I think the stable version is mostly determined by change in MMC/SDIO so 4.18 as mentioned Adrian seems most sensible. bcm4354 support was introduced in 3.14 and there were some earlier devices (4335) using same sleep mechanism. Regards, Arend