linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net
Cc: mgreer@animalcreek.com, bongsu.jeon@samsung.com, kuba@kernel.org,
	linux-nfc@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/12] nfc: constify, continued (part 2)
Date: Thu, 29 Jul 2021 13:58:32 +0200	[thread overview]
Message-ID: <f3521001-58f3-8c6c-5b07-9dd8dae0cba8@canonical.com> (raw)
In-Reply-To: <7b0ae615-dcdc-251e-4067-959b31c28159@canonical.com>

On 29/07/2021 13:35, Krzysztof Kozlowski wrote:
> On 29/07/2021 13:30, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>>
>> This series was applied to netdev/net-next.git (refs/heads/master):
>>
>> On Thu, 29 Jul 2021 12:40:10 +0200 you wrote:
>>> Hi,
>>>
>>> On top of:
>>> nfc: constify pointed data
>>> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski@canonical.com/
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>> [...]
>>
>> Here is the summary with links:
>>   - [01/12] nfc: constify passed nfc_dev
>>     https://git.kernel.org/netdev/net-next/c/dd8987a394c0
>>   - [02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send()
>>     https://git.kernel.org/netdev/net-next/c/894a6e158633
>>   - [03/12] nfc: port100: constify several pointers
>>     https://git.kernel.org/netdev/net-next/c/9a4af01c35a5
>>   - [04/12] nfc: trf7970a: constify several pointers
>>     https://git.kernel.org/netdev/net-next/c/ea050c5ee74a
>>   - [05/12] nfc: virtual_ncidev: constify pointer to nfc_dev
>>     https://git.kernel.org/netdev/net-next/c/83428dbbac51
>>   - [06/12] nfc: nfcsim: constify drvdata (struct nfcsim)
>>     https://git.kernel.org/netdev/net-next/c/582fdc98adc8
>>   - [07/12] nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg()
>>     https://git.kernel.org/netdev/net-next/c/6c755b1d2511
>>   - [08/12] nfc: fdp: use unsigned int as loop iterator
>>     https://git.kernel.org/netdev/net-next/c/c3e26b6dc1b4
>>   - [09/12] nfc: fdp: constify several pointers
>>     https://git.kernel.org/netdev/net-next/c/3d463dd5023b
>>   - [10/12] nfc: microread: constify several pointers
>>     https://git.kernel.org/netdev/net-next/c/a751449f8b47
>>   - [11/12] nfc: mrvl: constify several pointers
>>     https://git.kernel.org/netdev/net-next/c/fe53159fe3e0
> 
> Oh, folks, too fast :)
> 
> Sorry for the mess, but the patch 11/12 has one const which is wrong
> (I sent an email for it) and this should be on top of my
> previous set:
> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski@canonical.com/
> which I think you did not take in.
> 
> I am not sure if it compiles cleanly without the one above.

Hi David,

This fails because of missing patchset above:
../drivers/nfc/fdp/fdp.c: In function ‘fdp_nci_set_production_data’:
../drivers/nfc/fdp/fdp.c:116:60: warning: passing argument 4 of
‘nci_prop_cmd’ discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
  116 |  return nci_prop_cmd(ndev, NCI_OP_PROP_SET_PDATA_OID, len, data);

It also has one issue in patch 11/12. Can you drop this from
net-dev/master? I can send a v2 of both patchsets combined.

Best regards,
Krzysztof

      reply	other threads:[~2021-07-29 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 10:40 Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 01/12] nfc: constify passed nfc_dev Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send() Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 03/12] nfc: port100: constify several pointers Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 04/12] nfc: trf7970a: " Krzysztof Kozlowski
2021-07-29 15:58   ` Mark Greer
2021-07-29 10:40 ` [PATCH 05/12] nfc: virtual_ncidev: constify pointer to nfc_dev Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 06/12] nfc: nfcsim: constify drvdata (struct nfcsim) Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 07/12] nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg() Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 08/12] nfc: fdp: use unsigned int as loop iterator Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 09/12] nfc: fdp: constify several pointers Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 10/12] nfc: microread: " Krzysztof Kozlowski
2021-07-29 10:40 ` [PATCH 11/12] nfc: mrvl: " Krzysztof Kozlowski
2021-07-29 10:48   ` Krzysztof Kozlowski
2021-07-29 10:42 ` [PATCH 12/12] nfc: mrvl: constify static nfcmrvl_if_ops Krzysztof Kozlowski
2021-07-29 11:30 ` [PATCH 00/12] nfc: constify, continued (part 2) patchwork-bot+netdevbpf
2021-07-29 11:35   ` Krzysztof Kozlowski
2021-07-29 11:58     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3521001-58f3-8c6c-5b07-9dd8dae0cba8@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=bongsu.jeon@samsung.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfc@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=netdev@vger.kernel.org \
    --cc=patchwork-bot+netdevbpf@kernel.org \
    --subject='Re: [PATCH 00/12] nfc: constify, continued (part 2)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).