From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C63C3A5A4 for ; Fri, 30 Aug 2019 10:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10B2D23427 for ; Fri, 30 Aug 2019 10:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbfH3KTQ (ORCPT ); Fri, 30 Aug 2019 06:19:16 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:34330 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbfH3KTP (ORCPT ); Fri, 30 Aug 2019 06:19:15 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.1) (envelope-from ) id 1i3dzu-0003YT-0Z; Fri, 30 Aug 2019 12:19:14 +0200 Message-ID: Subject: Re: [PATCH 1/2] nl80211: Add NL80211_EXT_FEATURE_LIVE_IFTYPE_CHANGE From: Johannes Berg To: Denis Kenzior , linux-wireless@vger.kernel.org Date: Fri, 30 Aug 2019 12:19:13 +0200 In-Reply-To: <20190826162637.7535-1-denkenz@gmail.com> (sfid-20190826_183338_274894_5A6F600C) References: <20190826162637.7535-1-denkenz@gmail.com> (sfid-20190826_183338_274894_5A6F600C) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2019-08-26 at 11:26 -0500, Denis Kenzior wrote: > > + * Prior to Kernel 5.4, userspace applications should implement the > + * following behavior: I'm not sure mentioning the kernel version here does us any good? I mean, you really need to implement that behaviour regardless of kernel version, if NL80211_EXT_FEATURE_LIVE_IFTYPE_CHANGE isn't set. > + * @NL80211_EXT_FEATURE_LIVE_IFTYPE_CHANGE: This device supports switching > + * the IFTYPE of an interface without having to bring the device DOWN > + * first via RTNL. Exact semantics of this feature is driver > + * implementation dependent. That's not really nice. > For mac80211, the following restrictions > + * apply: > + * - Only devices currently in IFTYPE AP, P2P_GO, P2P_CLIENT, > + * STATION, ADHOC and OCB can be switched. > + * - The target IFTYPE must be one of: AP, P2P_GO, P2P_CLIENT, > + * STATION, ADHOC or OCB. > + * Other drivers are expected to follow similar restrictions. Maybe we should instead have a "bitmask of interface types that can be switched while live" or something like that? johannes