linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: linux-wireless@vger.kernel.org
Cc: linville@tuxdriver.com
Subject: [PATCH 5/6] carl9170: fix WARN_ON triggered by Broadcom HT STAs
Date: Sun, 26 Sep 2010 23:06:56 +0200	[thread overview]
Message-ID: <f656eb5cef04fed51344a7f95aa64b9958e6aecb.1285544496.git.chunkeey@googlemail.com> (raw)
In-Reply-To: <cover.1285544496.git.chunkeey@googlemail.com>

Broadcom's Windows driver for the 4313 advertises
an ampdu density of 7 => 16 us. The AR9170 MAC on
the other hand only supports densities up to 8 us.

This patch removes the noisy WARN_ON, because
there is nothing we can do about it.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
 drivers/net/wireless/ath/carl9170/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index a8b0cec..84bd38e 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -1248,7 +1248,7 @@ static int carl9170_op_ampdu_action(struct ieee80211_hw *hw,
 
 	switch (action) {
 	case IEEE80211_AMPDU_TX_START:
-		if (WARN_ON_ONCE(!sta_info->ht_sta))
+		if (!sta_info->ht_sta)
 			return -EOPNOTSUPP;
 
 		rcu_read_lock();
-- 
1.7.1


  parent reply	other threads:[~2010-09-27 17:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26 23:41 [PATCH 0/6] carl9170: updates Christian Lamparter
2010-09-26 19:28 ` [PATCH 1/6] carl9170: remove non-standard ba session teardown Christian Lamparter
2010-09-26 19:40 ` [PATCH 2/6] carl9170: angle brackets for wiki link Christian Lamparter
2010-09-26 19:48 ` [PATCH 3/6] carl9170: remove lost-frame workaround Christian Lamparter
2010-09-26 20:49 ` [PATCH 4/6] carl9170: fix tx_ampdu_upload counter Christian Lamparter
2010-09-26 21:06 ` Christian Lamparter [this message]
2010-09-26 23:36 ` [PATCH 6/6] carl9170: revamp carl9170_tx_prepare Christian Lamparter
2010-09-28 19:40 ` [PATCH 0/6] carl9170: updates John W. Linville
2010-09-30 13:00   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f656eb5cef04fed51344a7f95aa64b9958e6aecb.1285544496.git.chunkeey@googlemail.com \
    --to=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).