From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org,
chainofflowers <chainofflowers@posteo.net>
Subject: Re: [PATCH for-6.2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices
Date: Mon, 9 Jan 2023 10:55:58 +0100 [thread overview]
Message-ID: <fb3ad26f-0049-8f16-9075-ecad8f53a86e@broadcom.com> (raw)
In-Reply-To: <20230109095020.412475-1-arend.vanspriel@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]
On 1/9/2023 10:50 AM, Arend van Spriel wrote:
> A sanity check was introduced by [1] considering maximum flowrings
> above 256 as insane and effectively aborting the device probe. This
> resulted in regression for number of users and it is also tracked
> in bugzilla [2].
>
> [1] https://lore.kernel.org/all/20220929031001.9962-3-ian.lin@infineon.com/
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=216894
>
> Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle")
> Reported-by: chainofflowers <chainofflowers@posteo.net>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index ae57a9a3ab05..b67f6d0810b6 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -1228,7 +1228,7 @@ static int brcmf_pcie_init_ringbuffers(struct brcmf_pciedev_info *devinfo)
> BRCMF_NROF_H2D_COMMON_MSGRINGS;
> max_completionrings = BRCMF_NROF_D2H_COMMON_MSGRINGS;
> }
> - if (max_flowrings > 256) {
> + if (max_flowrings > 512) {
This check was added to detect firmware init failure. There should be a
better way than using this parameter. For now I decided to simply double
the limit to get the regression fixed.
> brcmf_err(bus, "invalid max_flowrings(%d)\n", max_flowrings);
> return -EIO;
> }
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2023-01-09 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 9:50 [PATCH for-6.2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices Arend van Spriel
2023-01-09 9:55 ` Arend van Spriel [this message]
2023-01-09 10:09 ` Linux kernel regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb3ad26f-0049-8f16-9075-ecad8f53a86e@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=chainofflowers@posteo.net \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).