From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>, Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: kstewart@linuxfoundation.org, johannes.berg@intel.com,
tiwai@suse.de, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew.zaborowski@intel.com, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, colin.king@canonical.com
Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post
Date: Mon, 8 Jan 2018 10:31:56 -0600 [thread overview]
Message-ID: <fc3e2558-c31f-289d-8413-33fef4f5ca64@lwfinger.net> (raw)
In-Reply-To: <20180108162128.6D37560B1D@smtp.codeaurora.org>
On 01/08/2018 10:21 AM, Kalle Valo wrote:
> Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>
>> b43_radio_2057_init_post is not called in an interrupt handler
>> nor holding a spinlock.
>> The function mdelay in it can be replaced with msleep, to reduce busy wait.
>>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>
> You submitted an identical patch a week earlier:
>
> https://patchwork.kernel.org/patch/10137671/
>
> How is this different? Also always add version number to the patch so that the
> maintainers can follow the changes easily:
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
I had negative comments on one of those due to the possibility of msleep(2)
extending as long as 20 msec. Until the author, or someone else, can test that
this is OK, then the mdelay(2) can only be replaced with usleep_range(2000, 3000).
NACK for both.
Larry
next prev parent reply other threads:[~2018-01-08 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-30 11:08 [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post Jia-Ju Bai
2017-12-30 18:49 ` Larry Finger
2018-01-08 16:21 ` Kalle Valo
[not found] ` <20180108162128.6D37560B1D@smtp.codeaurora.org>
2018-01-08 16:31 ` Larry Finger [this message]
2018-01-08 17:06 ` Kalle Valo
2018-01-09 1:36 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc3e2558-c31f-289d-8413-33fef4f5ca64@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andrew.zaborowski@intel.com \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.berg@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).