From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09347C432BE for ; Thu, 29 Jul 2021 10:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E13D760EBB for ; Thu, 29 Jul 2021 10:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236433AbhG2Ksp (ORCPT ); Thu, 29 Jul 2021 06:48:45 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:48370 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236309AbhG2Ksm (ORCPT ); Thu, 29 Jul 2021 06:48:42 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 2F70B3F112 for ; Thu, 29 Jul 2021 10:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627555719; bh=hgYfV6PUzr4ibh1B07XnMBlFCdNWiJgFxyAVIqgM0RM=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=j5LskC2qFE2kXjhZ5neucO7FLX8/9Ou0Ku/+rupPwsDpNHyWK/kqv9Z/BtORDPUZ9 cDbqQdXaomVLFa/kb4QSX1va+9RACrBszRvE77TcN8V8jekqzL9ZDygyksZfQcbJh0 k9+gghZQlmNzUwRg9cl7NvhGNSDf4NUQds0RTI1IKHyAQ9TF6AuY2gppXjDfBwknhW VOcjjXeWoCn1ldPNJjP/zMi5Dv2DWD0pBvuZs/FhcHsmzYIAIckR91jOWAZOmn/eDj haVTyBrvGQ/OM39fgcCZGKDuoWGy0wdFRIaFZgT0b4mdmhDeuliCfofZqR9IP177Fr 31OyoB1ZyRJWw== Received: by mail-ed1-f69.google.com with SMTP id d6-20020a50f6860000b02903bc068b7717so2757284edn.11 for ; Thu, 29 Jul 2021 03:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hgYfV6PUzr4ibh1B07XnMBlFCdNWiJgFxyAVIqgM0RM=; b=ZqJRyG7/gfX/J+Q56QylR+ZIHoNU2XpSO5KKGGs3OwMg5kk6pxrRWpi4Y7diSdAckp tEyuC9DiUEgilDvzfolHTMUadDG60F9LFtxomy5iKw7wGtIGrN2J8vQ9u3HdKZyi51h4 LSexQtDi98KzCE4d/N3VibnfFVVv879pPvjTfidXD2L9Lpr/I3t1OcKz9JnuLX+4H9Oe +/BJRegwLq7gXbnFNaPwZIBoKJXENOMvAU97WM/kIbCHXz9FponM6CpNm0zEYk1NeJ9O uQ9tN/G/R96aVuLsnPgB3N/Fdx6hdpUnVurv+EpcnfkCFTQM0OA5PLv6UTn9fo0CJGvy Tkrw== X-Gm-Message-State: AOAM530QQbXr79Tg4P6+xKLx9h8u/gF+RFQU1uMS7UhQRfrnZGof8n/C J3bTkXX4c9/YPooaHwbsFEFnM2zL06yVOO+GezaWQ5XVAJ59LsuHhOKbTyxVOUYu/Yt7877g2DV FEbwKnsGHCZce895ZjA+MR7MrvPgsBl116mRU0+W27Gfg X-Received: by 2002:a05:6402:1546:: with SMTP id p6mr5320726edx.206.1627555718146; Thu, 29 Jul 2021 03:48:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwY4QAn1JOv7y3Pw7jEkKTFfdNWaTLg8KUKIcj9ag9xPZRr+U6cjAwxcWvt9Mt8ejiQhrR1PQ== X-Received: by 2002:a05:6402:1546:: with SMTP id p6mr5320717edx.206.1627555718025; Thu, 29 Jul 2021 03:48:38 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id a35sm1053304edf.80.2021.07.29.03.48.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 03:48:37 -0700 (PDT) Subject: Re: [PATCH 11/12] nfc: mrvl: constify several pointers To: Mark Greer , Bongsu Jeon , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <20210729104022.47761-1-krzysztof.kozlowski@canonical.com> <20210729104022.47761-12-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Thu, 29 Jul 2021 12:48:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729104022.47761-12-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 29/07/2021 12:40, Krzysztof Kozlowski wrote: > Several functions do not modify pointed data so arguments and local > variables can be const for correctness and safety. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/nfc/nfcmrvl/fw_dnld.c | 16 +++++++++------- > drivers/nfc/nfcmrvl/i2c.c | 2 +- > drivers/nfc/nfcmrvl/main.c | 2 +- > drivers/nfc/nfcmrvl/nfcmrvl.h | 2 +- > drivers/nfc/nfcmrvl/spi.c | 4 ++-- > drivers/nfc/nfcmrvl/uart.c | 2 +- > 6 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/nfc/nfcmrvl/fw_dnld.c b/drivers/nfc/nfcmrvl/fw_dnld.c > index aaccb8b76b3e..edac56b01fd1 100644 > --- a/drivers/nfc/nfcmrvl/fw_dnld.c > +++ b/drivers/nfc/nfcmrvl/fw_dnld.c > @@ -129,7 +129,7 @@ static void fw_dnld_timeout(struct timer_list *t) > } > > static int process_state_reset(struct nfcmrvl_private *priv, > - struct sk_buff *skb) > + const struct sk_buff *skb) > { > if (sizeof(nci_pattern_core_reset_ntf) != skb->len || > memcmp(skb->data, nci_pattern_core_reset_ntf, > @@ -145,7 +145,8 @@ static int process_state_reset(struct nfcmrvl_private *priv, > return 0; > } > > -static int process_state_init(struct nfcmrvl_private *priv, struct sk_buff *skb) > +static int process_state_init(struct nfcmrvl_private *priv, > + const struct sk_buff *skb) > { > struct nci_core_set_config_cmd cmd; > > @@ -175,7 +176,7 @@ static void create_lc(struct nfcmrvl_private *priv) > } > > static int process_state_set_ref_clock(struct nfcmrvl_private *priv, > - struct sk_buff *skb) > + const struct sk_buff *skb) > { > struct nci_core_set_config_cmd cmd; > > @@ -221,7 +222,7 @@ static int process_state_set_ref_clock(struct nfcmrvl_private *priv, > } > > static int process_state_set_hi_config(struct nfcmrvl_private *priv, > - struct sk_buff *skb) > + const struct sk_buff *skb) > { > if (sizeof(nci_pattern_core_set_config_rsp) != skb->len || > memcmp(skb->data, nci_pattern_core_set_config_rsp, skb->len)) > @@ -232,7 +233,7 @@ static int process_state_set_hi_config(struct nfcmrvl_private *priv, > } > > static int process_state_open_lc(struct nfcmrvl_private *priv, > - struct sk_buff *skb) > + const struct sk_buff *skb) > { > if (sizeof(nci_pattern_core_conn_create_rsp) >= skb->len || > memcmp(skb->data, nci_pattern_core_conn_create_rsp, > @@ -347,7 +348,7 @@ static int process_state_fw_dnld(struct nfcmrvl_private *priv, > } > > static int process_state_close_lc(struct nfcmrvl_private *priv, > - struct sk_buff *skb) > + const struct sk_buff *skb) > { > if (sizeof(nci_pattern_core_conn_close_rsp) != skb->len || > memcmp(skb->data, nci_pattern_core_conn_close_rsp, skb->len)) > @@ -358,7 +359,8 @@ static int process_state_close_lc(struct nfcmrvl_private *priv, > return 0; > } > > -static int process_state_boot(struct nfcmrvl_private *priv, struct sk_buff *skb) > +static int process_state_boot(struct nfcmrvl_private *priv, > + const struct sk_buff *skb) > { > if (sizeof(nci_pattern_proprietary_boot_rsp) != skb->len || > memcmp(skb->data, nci_pattern_proprietary_boot_rsp, skb->len)) > diff --git a/drivers/nfc/nfcmrvl/i2c.c b/drivers/nfc/nfcmrvl/i2c.c > index 59a529e72d96..6e659e77c8a2 100644 > --- a/drivers/nfc/nfcmrvl/i2c.c > +++ b/drivers/nfc/nfcmrvl/i2c.c > @@ -182,8 +182,8 @@ static int nfcmrvl_i2c_parse_dt(struct device_node *node, > static int nfcmrvl_i2c_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > + const struct nfcmrvl_platform_data *pdata; > struct nfcmrvl_i2c_drv_data *drv_data; > - struct nfcmrvl_platform_data *pdata; > struct nfcmrvl_platform_data config; > int ret; > > diff --git a/drivers/nfc/nfcmrvl/main.c b/drivers/nfc/nfcmrvl/main.c > index 6e9e7ce8792c..d8e48bdaf652 100644 > --- a/drivers/nfc/nfcmrvl/main.c > +++ b/drivers/nfc/nfcmrvl/main.c > @@ -93,7 +93,7 @@ struct nfcmrvl_private *nfcmrvl_nci_register_dev(enum nfcmrvl_phy phy, > void *drv_data, > struct nfcmrvl_if_ops *ops, > struct device *dev, > - struct nfcmrvl_platform_data *pdata) > + const struct nfcmrvl_platform_data *pdata) > { > struct nfcmrvl_private *priv; > int rc; > diff --git a/drivers/nfc/nfcmrvl/nfcmrvl.h b/drivers/nfc/nfcmrvl/nfcmrvl.h > index a715543bc9bf..84fafa95965e 100644 > --- a/drivers/nfc/nfcmrvl/nfcmrvl.h > +++ b/drivers/nfc/nfcmrvl/nfcmrvl.h > @@ -94,7 +94,7 @@ struct nfcmrvl_private *nfcmrvl_nci_register_dev(enum nfcmrvl_phy phy, > void *drv_data, > struct nfcmrvl_if_ops *ops, > struct device *dev, > - struct nfcmrvl_platform_data *pdata); > + const struct nfcmrvl_platform_data *pdata); > > > void nfcmrvl_chip_reset(struct nfcmrvl_private *priv); > diff --git a/drivers/nfc/nfcmrvl/spi.c b/drivers/nfc/nfcmrvl/spi.c > index 66696321c645..7b015bb33fc9 100644 > --- a/drivers/nfc/nfcmrvl/spi.c > +++ b/drivers/nfc/nfcmrvl/spi.c > @@ -106,7 +106,7 @@ static struct nfcmrvl_if_ops spi_ops = { > .nci_update_config = nfcmrvl_spi_nci_update_config, > }; > > -static int nfcmrvl_spi_parse_dt(struct device_node *node, > +static int nfcmrvl_spi_parse_dt(const struct device_node *node, > struct nfcmrvl_platform_data *pdata) This one is not correct (yet) as it depends on changes in OF/IRQ. I just found compile configuration which triggers here warning. Please skip this one patch. Best regards, Krzysztof