From: Johannes Berg <johannes@sipsolutions.net>
To: Cedric VONCKEN <cedric.voncken@acksys.fr>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: WMM doesn't work for VLAN frame
Date: Thu, 18 Mar 2021 18:06:03 +0100 [thread overview]
Message-ID: <fee413b8499827dcdbd90cdb968aaa9210de750f.camel@sipsolutions.net> (raw)
In-Reply-To: <PR3PR01MB67144B33C65712847FFB558D906B9@PR3PR01MB6714.eurprd01.prod.exchangelabs.com> (sfid-20210316_161819_662475_641D2A95)
On Tue, 2021-03-16 at 15:15 +0000, Cedric VONCKEN wrote:
>
> Explantation of the issue
> 1. The validate_xmit_vlan function add the the vlan tag in the skb frame, set skb->protocol to VLAN protocol (0x8100) and set skb->vlan_tci to 0.
> 2. The cfg80211_classify8021d use these fields to determine the frame priority, but the skb->protocol value (0x8100) is not handled byt this function and this function return a default value 0.
(some line breaks would've been nice)
Well, since your own commit (!) c6ca5e28bc005 the VLAN TCI is used. If
the VLAN TCI is 0, then you don't get anything else?
Not sure what you were expecting different now?
Oh. You're saying that somehow the order of functions changed? But
validate_xmit_vlan() only pushes a hw offload vlan tag into the frame
(wifi devices aren't offload capable)?
johannes
prev parent reply other threads:[~2021-03-18 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 15:15 WMM doesn't work for VLAN frame Cedric VONCKEN
2021-03-18 17:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee413b8499827dcdbd90cdb968aaa9210de750f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=cedric.voncken@acksys.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).