linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ian Molton <ian@mnementh.co.uk>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>
Subject: Re: BUG: brcmfmac: add firmware feature detection for gscan feature breaks 43430a1
Date: Mon, 17 Jul 2017 21:53:56 +0200	[thread overview]
Message-ID: <ff344ee3-3feb-6886-8007-d8ed00386424@broadcom.com> (raw)
In-Reply-To: <e6635794-7c35-1a46-2d5b-68824c7b0657@mnementh.co.uk>

On 17-07-17 20:31, Ian Molton wrote:
> On 17/07/17 18:50, Ian Molton wrote:
>> Resent due to subject error. Apologies, Hante :)
>>
>> Hi Folks,
>>
>> 9fe929aaace6  brcmfmac: add firmware feature detection for gscan feature
>>
>> Completely breaks 43430a1 support.
> 
> Digging a bit deeper, this would *appear* to be one of a couple of
> possibilities;
> 
> 1) brcmf_sdio_hostmail() is missing code to handle a response of type
>    0x40012
> 2) The firmware is failing when asked to handle the new requiests, and
>    is going to la-la land.

taken a wrong turn straight into la-la land.

> Decoding the reply gives us HMB_DATA_DEVREADY or-ed with 0x40010
> 
> Since the upper half-word is masked, that leaves us with 0x10 which does
> not appear to be a defined state.
> 
> The driver does not handle this well, in any event.
> 
> My guess is that you are working on top of newer firmware than I have.
> Can you let me know what the latest public firmware is, and where I can
> get it?
> 
> I have version wl0: Aug 29 2016 20:48:16 version 7.45.41.26 (r640327)
> FWID 01-4527cfab

Not so much newer firmware, but I used a different chip when
implementing the multi-scheduled scan patches. I tried some other
devices, but not the bcm4343{0,8}. Now as far as I can see over here the
brcmfmac43430-sdio.bin is not built with gscan support so it should just
return firmware errorcode, ie. -23. So it would be interesting to see
what firmware has to say. Can you load the driver with
ignore_probe_fail=1 and dump the forensics file in debugfs.

Regards,
Arend

  reply	other threads:[~2017-07-17 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 17:50 BUG: brcmfmac: add firmware feature detection for gscan feature breaks 43430a1 Ian Molton
2017-07-17 18:31 ` Ian Molton
2017-07-17 19:53   ` Arend van Spriel [this message]
2017-07-17 20:13     ` Ian Molton
2017-07-17 20:36       ` Arend van Spriel
2017-07-17 20:41         ` Ian Molton
2017-07-17 21:31           ` Arend van Spriel
2017-07-17 22:02             ` Ian Molton
2017-07-17 22:10             ` Ian Molton
2017-07-18 19:49               ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff344ee3-3feb-6886-8007-d8ed00386424@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=ian@mnementh.co.uk \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).