linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 06/12] iwlwifi: yoyo: don't block dumping internal memory when not in SRAM mode
Date: Thu, 26 Mar 2020 14:55:04 +0200	[thread overview]
Message-ID: <iwlwifi.20200326145047.c657ccebe978.I69aad2d4904c4f8bb653c61e8781a2e07780054f@changeid> (raw)
In-Reply-To: <20200326125510.621842-1-luca@coelho.fi>

From: rotem saado <rotem.saado@intel.com>

When we have an assert during D3 we want to dump the internal
buffer memory even if are we working in DRAM debug mode.  We should not
block dumping it.

Signed-off-by: Rotem Saado <rotem.saado@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index d5dda93c3953..1746a0c472a5 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -1737,13 +1737,7 @@ iwl_dump_ini_mon_smem_get_size(struct iwl_fw_runtime *fwrt,
 			       struct iwl_dump_ini_region_data *reg_data)
 {
 	struct iwl_fw_ini_region_tlv *reg = (void *)reg_data->reg_tlv->data;
-	struct iwl_fw_ini_allocation_tlv *fw_mon_cfg;
-	u32 alloc_id = le32_to_cpu(reg->internal_buffer.alloc_id), size;
-
-	fw_mon_cfg = &fwrt->trans->dbg.fw_mon_cfg[alloc_id];
-	if (le32_to_cpu(fw_mon_cfg->buf_location) !=
-	    IWL_FW_INI_LOCATION_SRAM_PATH)
-		return 0;
+	u32 size;
 
 	size = le32_to_cpu(reg->internal_buffer.size);
 	if (!size)
-- 
2.25.1


  parent reply	other threads:[~2020-03-26 12:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 12:54 [PATCH 00/12] iwlwifi: updates intended for v5.7 2020-03-27 Luca Coelho
2020-03-26 12:54 ` [PATCH 01/12] iwlwifi: mvm: add support for non EDCA based measurements Luca Coelho
2020-03-26 12:55 ` [PATCH 02/12] iwlwifi: add support for version 2 of SOC_CONFIGURATION_CMD Luca Coelho
2020-03-26 12:55 ` [PATCH 03/12] iwlwifi: add trans_cfg for devices with long latency Luca Coelho
2020-03-26 12:55 ` [PATCH 04/12] iwlwifi: remove support for QnJ Hr STEP A Luca Coelho
2020-03-26 12:55 ` [PATCH 05/12] iwlwifi: remove support for QnJ HR FPGA Luca Coelho
2020-03-26 12:55 ` Luca Coelho [this message]
2020-03-26 12:55 ` [PATCH 07/12] iwlwifi: scan: support FW APIs with variable number of profiles Luca Coelho
2020-03-26 12:55 ` [PATCH 08/12] iwlwifi: yoyo: enable yoyo by default Luca Coelho
2020-03-26 12:55 ` [PATCH 09/12] iwlwifi: remove IWL_FW_DBG_DOMAIN macro Luca Coelho
2020-03-26 12:55 ` [PATCH 10/12] iwlwifi: bump FW API to 53 for 22000 series Luca Coelho
2020-03-26 12:55 ` [PATCH 11/12] iwlwifi: pcie: make iwl_pcie_cmdq_reclaim static Luca Coelho
2020-03-26 12:55 ` [PATCH 12/12] iwlwifi: mvm: remove newline from rs_pretty_print_rate() Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iwlwifi.20200326145047.c657ccebe978.I69aad2d4904c4f8bb653c61e8781a2e07780054f@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).