Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/3] iwlwifi: fixes intended for v5.10 2020-12-02
@ 2020-12-02 12:41 Luca Coelho
  2020-12-02 12:41 ` [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210 Luca Coelho
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Luca Coelho @ 2020-12-02 12:41 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless

From: Luca Coelho <luciano.coelho@intel.com>

Hi,

This is the second patchset with fixes for v5.10.

The changes are:

* Add a few PCI IDs for some new devices;
* Fix 160 vs. non-160 MHz device detection.

As usual, I'm pushing this to a pending branch, for kbuild bot.  And
since these are fixes for the rc series, please take them directly to
wireless-drivers.git, as we agreed.

Cheers,
Luca.


Golan Ben Ami (1):
  iwlwifi: pcie: add some missing entries for AX210

Luca Coelho (2):
  iwlwifi: pcie: add one missing entry for AX210
  iwlwifi: pcie: invert values of NO_160 device config entries

 drivers/net/wireless/intel/iwlwifi/iwl-config.h | 4 ++--
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c   | 6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210
  2020-12-02 12:41 [PATCH 0/3] iwlwifi: fixes intended for v5.10 2020-12-02 Luca Coelho
@ 2020-12-02 12:41 ` Luca Coelho
  2020-12-02 19:02   ` Kalle Valo
  2020-12-02 12:41 ` [PATCH 2/3] iwlwifi: pcie: invert values of NO_160 device config entries Luca Coelho
  2020-12-02 12:41 ` [PATCH 3/3] iwlwifi: pcie: add some missing entries for AX210 Luca Coelho
  2 siblings, 1 reply; 5+ messages in thread
From: Luca Coelho @ 2020-12-02 12:41 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless

From: Luca Coelho <luciano.coelho@intel.com>

The 0x0024 subsytem device ID was missing from the list, so some AX210
devices were not recognized.  Add it.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 129021f26791..466a967da39c 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -536,6 +536,7 @@ static const struct pci_device_id iwl_hw_card_ids[] = {
 
 	{IWL_PCI_DEVICE(0x2725, 0x0090, iwlax211_2ax_cfg_so_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0020, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0x0024, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0)},
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] iwlwifi: pcie: invert values of NO_160 device config entries
  2020-12-02 12:41 [PATCH 0/3] iwlwifi: fixes intended for v5.10 2020-12-02 Luca Coelho
  2020-12-02 12:41 ` [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210 Luca Coelho
@ 2020-12-02 12:41 ` Luca Coelho
  2020-12-02 12:41 ` [PATCH 3/3] iwlwifi: pcie: add some missing entries for AX210 Luca Coelho
  2 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2020-12-02 12:41 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless

From: Luca Coelho <luciano.coelho@intel.com>

The NO_160 flag specifies if the device doesn't have 160 MHz support,
but we errorneously assumed the opposite.  If the flag was set, we
were considering that 160 MHz was supported, but it's actually the
opposite.  Fix it by inverting the bits, i.e. NO_160 is 0x1 and 160
is 0x0.

Fixes: d6f2134a3831 ("iwlwifi: add mac/rf types and 160MHz to the device tables")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-config.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-config.h b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
index ca4967b81d01..580b07a43856 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-config.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-config.h
@@ -491,8 +491,8 @@ struct iwl_cfg {
 #define IWL_CFG_RF_ID_HR		0x7
 #define IWL_CFG_RF_ID_HR1		0x4
 
-#define IWL_CFG_NO_160			0x0
-#define IWL_CFG_160			0x1
+#define IWL_CFG_NO_160			0x1
+#define IWL_CFG_160			0x0
 
 #define IWL_CFG_CORES_BT		0x0
 #define IWL_CFG_CORES_BT_GNSS		0x5
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] iwlwifi: pcie: add some missing entries for AX210
  2020-12-02 12:41 [PATCH 0/3] iwlwifi: fixes intended for v5.10 2020-12-02 Luca Coelho
  2020-12-02 12:41 ` [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210 Luca Coelho
  2020-12-02 12:41 ` [PATCH 2/3] iwlwifi: pcie: invert values of NO_160 device config entries Luca Coelho
@ 2020-12-02 12:41 ` Luca Coelho
  2 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2020-12-02 12:41 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless

From: Golan Ben Ami <golan.ben.ami@intel.com>

Some subsytem device IDs were missing from the list, so some AX210
devices were not recognized.  Add them.

Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 466a967da39c..7b5ece380fbf 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -540,6 +540,11 @@ static const struct pci_device_id iwl_hw_card_ids[] = {
 	{IWL_PCI_DEVICE(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0xE020, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0xE024, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0x4020, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0x6020, iwlax210_2ax_cfg_ty_gf_a0)},
+	{IWL_PCI_DEVICE(0x2725, 0x6024, iwlax210_2ax_cfg_ty_gf_a0)},
 	{IWL_PCI_DEVICE(0x2725, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0)},
 	{IWL_PCI_DEVICE(0x2726, 0x0070, iwlax201_cfg_snj_hr_b0)},
 	{IWL_PCI_DEVICE(0x2726, 0x0074, iwlax201_cfg_snj_hr_b0)},
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210
  2020-12-02 12:41 ` [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210 Luca Coelho
@ 2020-12-02 19:02   ` Kalle Valo
  0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2020-12-02 19:02 UTC (permalink / raw)
  To: Luca Coelho; +Cc: linux-wireless

Luca Coelho <luca@coelho.fi> wrote:

> From: Luca Coelho <luciano.coelho@intel.com>
> 
> The 0x0024 subsytem device ID was missing from the list, so some AX210
> devices were not recognized.  Add it.
> 
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

3 patches applied to wireless-drivers.git, thanks.

5febcdef3090 iwlwifi: pcie: add one missing entry for AX210
568d3434178b iwlwifi: pcie: invert values of NO_160 device config entries
a0426b6caf18 iwlwifi: pcie: add some missing entries for AX210

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20201202143859.308eab4db42c.I3763196cd3f7bb36f3dcabf02ec4e7c4fe859c0f@changeid/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 12:41 [PATCH 0/3] iwlwifi: fixes intended for v5.10 2020-12-02 Luca Coelho
2020-12-02 12:41 ` [PATCH 1/3] iwlwifi: pcie: add one missing entry for AX210 Luca Coelho
2020-12-02 19:02   ` Kalle Valo
2020-12-02 12:41 ` [PATCH 2/3] iwlwifi: pcie: invert values of NO_160 device config entries Luca Coelho
2020-12-02 12:41 ` [PATCH 3/3] iwlwifi: pcie: add some missing entries for AX210 Luca Coelho

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git