linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ath9k: use spin_lock_bh() instead of spin_lock() in ath_tid_drain()
@ 2010-04-24  4:32 Jongman Heo
  2010-04-24 10:52 ` Ming Lei
  0 siblings, 1 reply; 2+ messages in thread
From: Jongman Heo @ 2010-04-24  4:32 UTC (permalink / raw)
  To: linux-wireless, ath9k-devel

commit a9f042cb ("ath9k: fix lockdep warning when unloading module")
changed spin_[un]lock() to
spin_[un]lock_bh() in ath_tx_node_cleanup(), but didn't change those
in ath_tid_drain().

Signed-off-by: Jongman Heo <jongman.heo@gmail.com>

diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
b/drivers/net/wireless/ath/ath9k/xmit.c
index 294b486..daf073b 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -235,9 +235,9 @@ static void ath_tid_drain(struct ath_softc *sc,
struct ath_txq *txq,
 		if (bf_isretried(bf))
 			ath_tx_update_baw(sc, tid, bf->bf_seqno);

-		spin_unlock(&txq->axq_lock);
+		spin_unlock_bh(&txq->axq_lock);
 		ath_tx_complete_buf(sc, bf, txq, &bf_head, 0, 0);
-		spin_lock(&txq->axq_lock);
+		spin_lock_bh(&txq->axq_lock);
 	}

 	tid->seq_next = tid->seq_start;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ath9k: use spin_lock_bh() instead of spin_lock() in ath_tid_drain()
  2010-04-24  4:32 [PATCH] ath9k: use spin_lock_bh() instead of spin_lock() in ath_tid_drain() Jongman Heo
@ 2010-04-24 10:52 ` Ming Lei
  0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2010-04-24 10:52 UTC (permalink / raw)
  To: Jongman Heo; +Cc: linux-wireless, ath9k-devel

2010/4/24 Jongman Heo <jongman.heo@gmail.com>:
> commit a9f042cb ("ath9k: fix lockdep warning when unloading module")
> changed spin_[un]lock() to
> spin_[un]lock_bh() in ath_tx_node_cleanup(), but didn't change those
> in ath_tid_drain().

Did you see any lockdep warning due to ath_tid_drain?

It is not necessary since bh has been disabled before calling
ath_tid_drain.


-- 
Lei Ming

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-24 10:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-24  4:32 [PATCH] ath9k: use spin_lock_bh() instead of spin_lock() in ath_tid_drain() Jongman Heo
2010-04-24 10:52 ` Ming Lei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).