linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCHv4 0/2] mac80211: cfg80211: dynamic ps timeout based on pm-qos
Date: Mon, 3 May 2010 15:44:39 -0700	[thread overview]
Message-ID: <o2z43e72e891005031544ufd3f84a5g4e0a3a0dceac8002@mail.gmail.com> (raw)
In-Reply-To: <87633al6di.fsf@purkki.valot.fi>

On Thu, Apr 29, 2010 at 6:45 AM, Kalle Valo <kvalo@adurom.com> wrote:
> Juuso Oikarinen <juuso.oikarinen@nokia.com> writes:
>
>> These patches propose a way to adjust the dynamic ps timeout in the
>> mac80211 based on the pm-qos network latency value. This allows user
>> space to influence the level of power saving performed by the
>> mac80211.
>>
>> v4 of these patches change the way pm qos network latency ranges
>> converted to dynamic ps timeout values a little bit saner. Unlike
>> the previous set of patches, now the latancy values make sense in a
>> wider scope than this ps timeout thing only. I hope this makes them
>> somewhat more future-proof.
>
> This looks very good now. Bonus points for adding the comment about
> the two second value!
>
> Thank you for implementing this.

Even more bonus points (if this was a video game you'd get an extra
life) if you add the new changes on the documentation here:

http://wireless.kernel.org/en/developers/Documentation/pm-qos

  Luis

  reply	other threads:[~2010-05-03 22:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 11:47 [RFC PATCHv4 0/2] mac80211: cfg80211: dynamic ps timeout based on pm-qos Juuso Oikarinen
2010-04-21 11:47 ` [RFC PATCHv4 1/2] mac80211: Determine dynamic PS timeout based on ps-qos network latency Juuso Oikarinen
2010-04-21 11:47 ` [RFC PATCHv4 2/2] cfg80211: Remove default dynamic PS timeout value Juuso Oikarinen
2010-04-29 13:45 ` [RFC PATCHv4 0/2] mac80211: cfg80211: dynamic ps timeout based on pm-qos Kalle Valo
2010-05-03 22:44   ` Luis R. Rodriguez [this message]
2010-05-04  5:25     ` Juuso Oikarinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=o2z43e72e891005031544ufd3f84a5g4e0a3a0dceac8002@mail.gmail.com \
    --to=mcgrof@gmail.com \
    --cc=juuso.oikarinen@nokia.com \
    --cc=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).