[PATCH wpan-tools] wpan-hwsim: fix long option argument option for dot

[PATCH wpan-tools] wpan-hwsim: fix long option argument option for dot

[Alexander Aring]

This patch fixes the long option argument option to no argument. The dot
argument doesn't require any postponed argument.

Signed-off-by: Alexander Aring <aring@mojatatu.com>
---
 wpan-hwsim/wpan-hwsim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wpan-hwsim/wpan-hwsim.c b/wpan-hwsim/wpan-hwsim.c
index dcddb09..3e54348 100644
--- a/wpan-hwsim/wpan-hwsim.c
+++ b/wpan-hwsim/wpan-hwsim.c
@@ -393,7 +393,7 @@ int main(int argc, const char *argv[])
 		static struct option long_options[] = {
 			{"help",	no_argument,		0,	'h' },
 			{"version",	no_argument,		0,	'v' },
-			{"dot",		required_argument,	0,	'd' },
+			{"dot",		no_argument,		0,	'd' },
 			{"ignore",	required_argument,	0,	'i' },
 			{0,				0,	0,	0 }
 		};
-- 
2.11.0

Re: [PATCH wpan-tools] wpan-hwsim: fix long option argument option for dot

[Stefan Schmidt]

Hello.

On 16/10/2018 17:38, Alexander Aring wrote:
> This patch fixes the long option argument option to no argument. The dot
> argument doesn't require any postponed argument.
> 
> Signed-off-by: Alexander Aring <aring@mojatatu.com>
> ---
>  wpan-hwsim/wpan-hwsim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wpan-hwsim/wpan-hwsim.c b/wpan-hwsim/wpan-hwsim.c
> index dcddb09..3e54348 100644
> --- a/wpan-hwsim/wpan-hwsim.c
> +++ b/wpan-hwsim/wpan-hwsim.c
> @@ -393,7 +393,7 @@ int main(int argc, const char *argv[])
>  		static struct option long_options[] = {
>  			{"help",	no_argument,		0,	'h' },
>  			{"version",	no_argument,		0,	'v' },
> -			{"dot",		required_argument,	0,	'd' },
> +			{"dot",		no_argument,		0,	'd' },
>  			{"ignore",	required_argument,	0,	'i' },
>  			{0,				0,	0,	0 }
>  		};
> 

Applied to wpan-tools repo.

Is there anythign else left you wanted to have in before we look into a
new release?

regards
Stefan Schmidt

Re: [PATCH wpan-tools] wpan-hwsim: fix long option argument option for dot

[Alexander Aring]

Hi,

On Wed, Oct 24, 2018 at 05:28:59PM +0200, Stefan Schmidt wrote:
> Hello.
> 
> On 16/10/2018 17:38, Alexander Aring wrote:
> > This patch fixes the long option argument option to no argument. The dot
> > argument doesn't require any postponed argument.
> > 
> > Signed-off-by: Alexander Aring <aring@mojatatu.com>
> > ---
> >  wpan-hwsim/wpan-hwsim.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/wpan-hwsim/wpan-hwsim.c b/wpan-hwsim/wpan-hwsim.c
> > index dcddb09..3e54348 100644
> > --- a/wpan-hwsim/wpan-hwsim.c
> > +++ b/wpan-hwsim/wpan-hwsim.c
> > @@ -393,7 +393,7 @@ int main(int argc, const char *argv[])
> >  		static struct option long_options[] = {
> >  			{"help",	no_argument,		0,	'h' },
> >  			{"version",	no_argument,		0,	'v' },
> > -			{"dot",		required_argument,	0,	'd' },
> > +			{"dot",		no_argument,		0,	'd' },
> >  			{"ignore",	required_argument,	0,	'i' },
> >  			{0,				0,	0,	0 }
> >  		};
> > 
> 
> Applied to wpan-tools repo.
> 
> Is there anythign else left you wanted to have in before we look into a
> new release?
> 

no I might figure them out when debian backports ship 4.19 kernel.

- Alex