From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: h.morris@cascoda.com, alex.aring@gmail.com,
stefan@datenfreihafen.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next] ieee802154: ca8210: remove a dead branch
Date: Mon, 10 Dec 2018 12:04:02 -0800 (PST) [thread overview]
Message-ID: <20181210.120402.2087888281534527051.davem@davemloft.net> (raw)
In-Reply-To: <20181210113443.22796-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 10 Dec 2018 19:34:43 +0800
> Fix follwing gcc warning:
>
> drivers/net/ieee802154/ca8210.c:730:10: warning:
> comparison is always false due to limited range of data type [-Wtype-limits]
>
> the variable 'len' is of type u8 and cannot greater than
> CA8210_SPI_BUF_SIZE , which is 256.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Then bug is the variable type here.
We are reading a u8 from buf[], then adding 2, which can overflow.
'len' should be an unsigned int or similar.
next prev parent reply other threads:[~2018-12-10 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:34 [PATCH net-next] ieee802154: ca8210: remove a dead branch YueHaibing
2018-12-10 20:04 ` David Miller [this message]
2018-12-11 1:51 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210.120402.2087888281534527051.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.aring@gmail.com \
--cc=h.morris@cascoda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).