From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f195.google.com ([209.85.166.195]:37304 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbeLXQNE (ORCPT ); Mon, 24 Dec 2018 11:13:04 -0500 Received: by mail-it1-f195.google.com with SMTP id b5so15695785iti.2 for ; Mon, 24 Dec 2018 08:13:04 -0800 (PST) Date: Mon, 24 Dec 2018 11:12:58 -0500 From: Alexander Aring Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings Message-ID: <20181224161258.gvvq25k3ufuyt3ej@x220t> References: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com> Sender: linux-wpan-owner@vger.kernel.org List-ID: To: YueHaibing Cc: Alexander Aring , Jukka Rissanen , linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org, kernel-janitors@vger.kernel.org Hi, On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > Ok. > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing Acked-by: Alexander Aring Reminder to myself: We should finally move this crap away which is even not net namespace aware and introduce a stable uapi. I would love to see it that it can be controlled by iproute2. :-) - Alex