Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
  • * Re: [PATCH rpld 0/6] Mixed bag of rpld patches
           [not found] <20190918195819.7492-1-stefan@datenfreihafen.org>
           [not found] ` <20190918195819.7492-3-stefan@datenfreihafen.org>
    @ 2019-12-20 23:06 ` Alexander Aring
      2019-12-22 22:07   ` Stefan Schmidt
      2020-01-09 22:38 ` Alexander Aring
      2 siblings, 1 reply; 5+ messages in thread
    From: Alexander Aring @ 2019-12-20 23:06 UTC (permalink / raw)
      To: Stefan Schmidt; +Cc: linux-wpan - ML
    
    Hi Stefan,
    
    On Wed, 18 Sep 2019 at 15:58, Stefan Schmidt <stefan@datenfreihafen.org> wrote:
    >
    > Hello.
    >
    > This series does really not have any theme, besides me starting
    > to look into rpld and playing around with it.
    >
    > I had to fix meson for my lua detection and make sure the ifdef
    > for SCOPE_ID is honoured. After getting it all building locally
    > I added Travis support and submitted builds to Coverity.
    > Afterwards I did a quick run through the reports from address
    > sanitizer and coverity scan.
    >
    > Not sure if you would prefer review for rpld as patches here on
    > the list or as pull requests on github. Up to you.
    >
    
    I can't deal with the github gui! I click always the wrong buttons
    there. Thanks for setting up this travis support, does it work like
    wpan-tools to push it into branch "coverity_scan"?
    I would like to review patches via mail, what do you prefer? What is
    the procedure when somebody submits pull requests on github then,
    somebody of us send it via mail? Sounds more work... Can we do both as
    "whatever you like"? Can github somehow send pull request via github
    to this mailinglist? Would be nice to have something to connect the
    whole github thing to a mailinglist and you can control it with that
    as well... at least the commenting system but I think this isn't
    possible and the new kids wants all pull request via github gui. We
    didn't answered this question for wpan-tools as well and I once
    clicked the "merge" button (actually not by accident).
    
    Also how we do that with signed off by thing? I can still fix it
    somehow what I did there...
    
    - Alex
    
    ^ permalink raw reply	[flat|nested] 5+ messages in thread
  • * Re: [PATCH rpld 0/6] Mixed bag of rpld patches
           [not found] <20190918195819.7492-1-stefan@datenfreihafen.org>
           [not found] ` <20190918195819.7492-3-stefan@datenfreihafen.org>
      2019-12-20 23:06 ` [PATCH rpld 0/6] Mixed bag of rpld patches Alexander Aring
    @ 2020-01-09 22:38 ` Alexander Aring
      2020-01-10  8:54   ` Stefan Schmidt
      2 siblings, 1 reply; 5+ messages in thread
    From: Alexander Aring @ 2020-01-09 22:38 UTC (permalink / raw)
      To: Stefan Schmidt; +Cc: linux-wpan
    
    Hi Stefan,
    
    On Wed, Sep 18, 2019 at 09:58:13PM +0200, Stefan Schmidt wrote:
    > Hello.
    > 
    > This series does really not have any theme, besides me starting
    > to look into rpld and playing around with it.
    > 
    > I had to fix meson for my lua detection and make sure the ifdef
    > for SCOPE_ID is honoured. After getting it all building locally
    > I added Travis support and submitted builds to Coverity.
    > Afterwards I did a quick run through the reports from address
    > sanitizer and coverity scan.
    > 
    > Not sure if you would prefer review for rpld as patches here on
    > the list or as pull requests on github. Up to you.
    > 
    > Stefan Schmidt (6):
    >   build: test various names for our lua dependency
    >   send: make sure we check on scope id usage
    >   ci: travis: initial setup for CI testing with Travis
    >   config : fix leaks on error paths
    >   socket: make sure we close our socket if setsockopt() fails
    >   send: ensure we free the buffer after sending the message
    
    I tested the patch series and so far it still compiles on my machine.
    
    Reviewed-by: Alexander Aring <alex.aring@gmail.com>
    
    on all patches.
    
    - Alex
    
    ^ permalink raw reply	[flat|nested] 5+ messages in thread

  • end of thread, back to index
    
    Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <20190918195819.7492-1-stefan@datenfreihafen.org>
         [not found] ` <20190918195819.7492-3-stefan@datenfreihafen.org>
    2019-12-20 22:52   ` [PATCH rpld 2/6] send: make sure we check on scope id usage Alexander Aring
    2019-12-20 23:06 ` [PATCH rpld 0/6] Mixed bag of rpld patches Alexander Aring
    2019-12-22 22:07   ` Stefan Schmidt
    2020-01-09 22:38 ` Alexander Aring
    2020-01-10  8:54   ` Stefan Schmidt
    

    Linux-WPAN Archive on lore.kernel.org
    
    Archives are clonable:
    	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git
    
    	# If you have public-inbox 1.1+ installed, you may
    	# initialize and index your mirror using the following commands:
    	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
    		linux-wpan@vger.kernel.org
    	public-inbox-index linux-wpan
    
    Example config snippet for mirrors
    
    Newsgroup available over NNTP:
    	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan
    
    
    AGPL code for this site: git clone https://public-inbox.org/public-inbox.git