From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32686C43470 for ; Mon, 12 Apr 2021 16:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB92D6128E for ; Mon, 12 Apr 2021 16:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244150AbhDLQgr (ORCPT ); Mon, 12 Apr 2021 12:36:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:35638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244994AbhDLQdk (ORCPT ); Mon, 12 Apr 2021 12:33:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 33331613CF; Mon, 12 Apr 2021 16:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244799; bh=8HpKkNSRru0z8WcDe7S90lfAhdtFVrp/8hrFMhRpK2Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CRvmP+zSHkgmswk9ZXjJDHpDsyBD8qkOR1h+n5kmfft0k9anLCxOUj98vBwGwugDI o8X3k+QEbYr8RGN0x/aENiJvz0jc2DzlrZqAySyom7rbYdeLZYcz2+a1nt0Ip2FYa+ QI93/oi9leQd7heUsTu+VtOy2a9Z0Rm9+7iud+JL/Z4dgptKRwH5X7NElp3qLBLHSO XuP4gyFGZcV2O8orfk2mvp/FciKKy44oxzErwPwbmZPlXX0n3gmJZz2hlaIj28nZmT eEhJ17ydmribk3NVYy9kAVfojhbd0SFn/WlKxBznjwt/smH8znX3VALyXxztcTEZS1 S51wxatEt42WA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavel Skripkin , syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com, "David S . Miller" , Sasha Levin , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 06/25] drivers: net: fix memory leak in atusb_probe Date: Mon, 12 Apr 2021 12:26:11 -0400 Message-Id: <20210412162630.315526-6-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162630.315526-1-sashal@kernel.org> References: <20210412162630.315526-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org From: Pavel Skripkin [ Upstream commit 6b9fbe16955152626557ec6f439f3407b7769941 ] syzbot reported memory leak in atusb_probe()[1]. The problem was in atusb_alloc_urbs(). Since urb is anchored, we need to release the reference to correctly free the urb backtrace: [] kmalloc include/linux/slab.h:559 [inline] [] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74 [] atusb_alloc_urbs drivers/net/ieee802154/atusb.c:362 [inline][2] [] atusb_probe+0x158/0x820 drivers/net/ieee802154/atusb.c:1038 [1] Reported-by: syzbot+28a246747e0a465127f3@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ieee802154/atusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c index 8e2cbc88df98..2c4274453c15 100644 --- a/drivers/net/ieee802154/atusb.c +++ b/drivers/net/ieee802154/atusb.c @@ -346,6 +346,7 @@ static int atusb_alloc_urbs(struct atusb *atusb, int n) return -ENOMEM; } usb_anchor_urb(urb, &atusb->idle_urbs); + usb_free_urb(urb); n--; } return 0; -- 2.30.2