From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH wpan-next v3 11/11] net: ieee802154: ca8210: Call _xmit_error() when a transmission fails
Date: Thu, 3 Mar 2022 19:25:08 +0100 [thread overview]
Message-ID: <20220303182508.288136-12-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220303182508.288136-1-miquel.raynal@bootlin.com>
ieee802154_xmit_error() is the right helper to call when a transmission
has failed. Let's use it instead of open-coding it.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/net/ieee802154/ca8210.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 116aece191cd..b1eb74200f23 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -1729,11 +1729,11 @@ static int ca8210_async_xmit_complete(
status
);
if (status != IEEE802154_TRANSACTION_OVERFLOW) {
- dev_kfree_skb_any(priv->tx_skb);
- ieee802154_wake_queue(priv->hw);
+ ieee802154_xmit_error(priv->hw, priv->tx_skb, status);
return 0;
}
}
+
ieee802154_xmit_complete(priv->hw, priv->tx_skb, true);
return 0;
--
2.27.0
prev parent reply other threads:[~2022-03-03 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 18:24 [PATCH wpan-next v3 00/11] ieee802154: Better Tx error handling Miquel Raynal
2022-03-03 18:24 ` [PATCH wpan-next v3 01/11] net: ieee802154: Enhance/fix the names of the MLME return codes Miquel Raynal
2022-03-03 18:24 ` [PATCH wpan-next v3 02/11] net: ieee802154: Fill the list of " Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 03/11] net: mac802154: Create a transmit error helper Miquel Raynal
2022-03-04 4:30 ` Jakub Kicinski
2022-03-04 8:04 ` Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 04/11] net: mac802154: Save a global error code on transmissions Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 05/11] net: ieee802154: at86rf230: Assume invalid TRAC if not recognized Miquel Raynal
2022-03-13 20:06 ` Alexander Aring
2022-03-03 18:25 ` [PATCH wpan-next v3 06/11] net: ieee802154: at86rf230: Return early in case of error Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 07/11] net: ieee802154: at86rf230: Provide meaningful error codes when possible Miquel Raynal
2022-03-13 20:16 ` Alexander Aring
2022-03-18 7:56 ` Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 08/11] net: ieee802154: at86rf230: Call _xmit_error() when a transmission fails Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 09/11] net: ieee802154: atusb: " Miquel Raynal
2022-03-13 20:20 ` Alexander Aring
2022-03-18 7:57 ` Miquel Raynal
2022-03-03 18:25 ` [PATCH wpan-next v3 10/11] net: ieee802154: ca8210: Use core return codes instead of hardcoding them Miquel Raynal
2022-03-03 18:25 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303182508.288136-12-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=frederic.blain@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).