From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v5 07/11] net: ieee802154: at86rf230: Call _xmit_bus_error() when a bus error occurs
Date: Wed, 6 Apr 2022 17:34:37 +0200 [thread overview]
Message-ID: <20220406153441.1667375-8-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220406153441.1667375-1-miquel.raynal@bootlin.com>
ieee802154_xmit_bus_error() is the right helper to call when a transmission
has failed. Let's use it instead of open-coding it. This also has the
advantage of forwarding a generic IEEE80254_SYSTEM_ERROR reason.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/net/ieee802154/at86rf230.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index cafc786aab57..f219732ab301 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -346,8 +346,7 @@ at86rf230_async_bus_error_recover_complete(void *context)
if (lp->was_tx) {
lp->was_tx = 0;
- dev_kfree_skb_any(lp->tx_skb);
- ieee802154_wake_queue(lp->hw);
+ ieee802154_xmit_bus_error(lp->hw, lp->tx_skb);
}
}
--
2.27.0
next prev parent reply other threads:[~2022-04-06 17:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 15:34 [PATCH v5 00/11] ieee802154: Better Tx error handling Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 01/11] net: ieee802154: Enhance/fix the names of the MLME return codes Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 02/11] net: ieee802154: Fill the list of " Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 03/11] net: mac802154: Save a global error code on transmissions Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 04/11] net: mac802154: Create a transmit error helper Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 05/11] net: mac802154: Create a transmit bus " Miquel Raynal
2022-04-06 21:43 ` Alexander Aring
2022-04-07 7:56 ` Miquel Raynal
2022-04-07 10:02 ` Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 06/11] net: ieee802154: at86rf230: Rename the asynchronous " Miquel Raynal
2022-04-06 21:57 ` Alexander Aring
2022-04-07 8:05 ` Miquel Raynal
2022-04-25 12:22 ` Alexander Aring
2022-04-06 15:34 ` Miquel Raynal [this message]
2022-04-06 15:34 ` [PATCH v5 08/11] net: ieee802154: at86rf230: Drop debugfs support Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 09/11] net: ieee802154: atusb: Call _xmit_error() when a transmission fails Miquel Raynal
2022-04-06 21:58 ` Alexander Aring
2022-04-07 8:06 ` Miquel Raynal
2022-04-25 12:35 ` Alexander Aring
2022-04-25 13:05 ` Alexander Aring
2022-04-25 13:16 ` Miquel Raynal
2022-04-25 13:43 ` Alexander Aring
2022-04-06 15:34 ` [PATCH v5 10/11] net: ieee802154: ca8210: Use core return codes instead of hardcoding them Miquel Raynal
2022-04-06 15:34 ` [PATCH v5 11/11] net: ieee802154: ca8210: Call _xmit_error() when a transmission fails Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406153441.1667375-8-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=frederic.blain@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).