linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, Alexander Aring <alex.aring@gmail.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	Sergey Lapin <slapin@ossfans.org>,
	linux-wpan@vger.kernel.org
Subject: Re: [PATCH net 04/16] nl802154: add missing attribute validation
Date: Tue, 3 Mar 2020 16:38:22 +0100	[thread overview]
Message-ID: <20cfaa15-b4d2-9b2b-aa3f-198cef5765a2@datenfreihafen.org> (raw)
In-Reply-To: <20200303050526.4088735-5-kuba@kernel.org>

Hello.

On 03.03.20 06:05, Jakub Kicinski wrote:
> Add missing attribute validation for several u8 types.
> 
> Fixes: 2c21d11518b6 ("net: add NL802154 interface for configuration of 802.15.4 devices")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: Alexander Aring <alex.aring@gmail.com>
> CC: Stefan Schmidt <stefan@datenfreihafen.org>
> CC: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> CC: Sergey Lapin <slapin@ossfans.org>
> CC: linux-wpan@vger.kernel.org
> ---
>   net/ieee802154/nl_policy.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c
> index 2c7a38d76a3a..824e7e84014c 100644
> --- a/net/ieee802154/nl_policy.c
> +++ b/net/ieee802154/nl_policy.c
> @@ -21,6 +21,11 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = {
>   	[IEEE802154_ATTR_HW_ADDR] = { .type = NLA_HW_ADDR, },
>   	[IEEE802154_ATTR_PAN_ID] = { .type = NLA_U16, },
>   	[IEEE802154_ATTR_CHANNEL] = { .type = NLA_U8, },
> +	[IEEE802154_ATTR_BCN_ORD] = { .type = NLA_U8, },
> +	[IEEE802154_ATTR_SF_ORD] = { .type = NLA_U8, },
> +	[IEEE802154_ATTR_PAN_COORD] = { .type = NLA_U8, },
> +	[IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, },
> +	[IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, },
>   	[IEEE802154_ATTR_PAGE] = { .type = NLA_U8, },
>   	[IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, },
>   	[IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, },
> 


Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

regards
Stefan Schmidt

  reply	other threads:[~2020-03-03 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200303050526.4088735-1-kuba@kernel.org>
2020-03-03  5:05 ` [PATCH net 04/16] nl802154: add missing attribute validation Jakub Kicinski
2020-03-03 15:38   ` Stefan Schmidt [this message]
2020-03-03  5:05 ` [PATCH net 05/16] nl802154: add missing attribute validation for dev_type Jakub Kicinski
2020-03-03 15:39   ` Stefan Schmidt
2020-03-03 17:55     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20cfaa15-b4d2-9b2b-aa3f-198cef5765a2@datenfreihafen.org \
    --to=stefan@datenfreihafen.org \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dbaryshkov@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=slapin@ossfans.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).