From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alex.aring@gmail.com,
davem@davemloft.net, kuba@kernel.org, stefan@datenfreihafen.org
Subject: Re: [PATCH] net: ieee802154: fix error return code of dgram_sendmsg()
Date: Mon, 8 Mar 2021 20:18:35 +0800 [thread overview]
Message-ID: <3634b7c6-340b-3d6d-ccce-c2a95319ca9e@gmail.com> (raw)
In-Reply-To: <d373b42c-0057-48b3-4667-bfa53a99f040@gmail.com>
On 2021/3/8 18:19, Heiner Kallweit wrote:
> On 08.03.2021 10:31, Jia-Ju Bai wrote:
>> When sock_alloc_send_skb() returns NULL to skb, no error return code of
>> dgram_sendmsg() is assigned.
>> To fix this bug, err is assigned with -ENOMEM in this case.
>>
> Please stop sending such nonsense. Basically all such patches you
> sent so far are false positives. You have to start thinking,
> don't blindly trust your robot.
> In the case here the err variable is populated by sock_alloc_send_skb().
Ah, sorry, it is my fault :(
I did not notice that the err variable is populated by
sock_alloc_send_skb().
I will think more carefully before sending patches.
By the way, I wonder how to report and discuss possible bugs that I am
not quite sure of?
Some people told me that sending patches is better than reporting bugs
via Bugzilla, so I write the patches of these possible bugs...
Do you have any advice?
Thanks a lot!
Best wishes,
Jia-Ju Bai
>
>> Fixes: 78f821b64826 ("ieee802154: socket: put handling into one file")
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>> ---
>> net/ieee802154/socket.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
>> index a45a0401adc5..a750b37c7e73 100644
>> --- a/net/ieee802154/socket.c
>> +++ b/net/ieee802154/socket.c
>> @@ -642,8 +642,10 @@ static int dgram_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
>> skb = sock_alloc_send_skb(sk, hlen + tlen + size,
>> msg->msg_flags & MSG_DONTWAIT,
>> &err);
>> - if (!skb)
>> + if (!skb) {
>> + err = -ENOMEM;
>> goto out_dev;
>> + }
>>
>> skb_reserve(skb, hlen);
>>
>>
next prev parent reply other threads:[~2021-03-08 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 9:31 [PATCH] net: ieee802154: fix error return code of dgram_sendmsg() Jia-Ju Bai
2021-03-08 10:19 ` Heiner Kallweit
2021-03-08 12:18 ` Jia-Ju Bai [this message]
2021-03-08 13:33 ` Heiner Kallweit
2021-03-08 13:49 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3634b7c6-340b-3d6d-ccce-c2a95319ca9e@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).