linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Lin Ma <linma@zju.edu.cn>,
	michael.hennerich@analog.com, alex.aring@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-wpan@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0] ieee802154/adf7242: defer destroy_workqueue call
Date: Tue, 23 Aug 2022 10:03:00 +0200	[thread overview]
Message-ID: <4325be90-eeb3-2bdb-5ee5-7e567d633aa6@datenfreihafen.org> (raw)
In-Reply-To: <20220808034224.12642-1-linma@zju.edu.cn>

Hello.

On 08.08.22 05:42, Lin Ma wrote:
> There is a possible race condition (use-after-free) like below
> 
>    (FREE)                     |  (USE)
>    adf7242_remove             |  adf7242_channel
>     cancel_delayed_work_sync  |
>      destroy_workqueue (1)    |   adf7242_cmd_rx
>                               |    mod_delayed_work (2)
>                               |
> 
> The root cause for this race is that the upper layer (ieee802154) is
> unaware of this detaching event and the function adf7242_channel can
> be called without any checks.
> 
> To fix this, we can add a flag write at the beginning of adf7242_remove
> and add flag check in adf7242_channel. Or we can just defer the
> destructive operation like other commit 3e0588c291d6 ("hamradio: defer
> ax25 kfree after unregister_netdev") which let the
> ieee802154_unregister_hw() to handle the synchronization. This patch
> takes the second option.
> 
> Fixes: 58e9683d1475 ("net: ieee802154: adf7242: Fix OCL calibration
> runs")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt

      parent reply	other threads:[~2022-08-23  8:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08  3:42 [PATCH v0] ieee802154/adf7242: defer destroy_workqueue call Lin Ma
2022-08-08  7:43 ` Hennerich, Michael
2022-08-23  8:03 ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4325be90-eeb3-2bdb-5ee5-7e567d633aa6@datenfreihafen.org \
    --to=stefan@datenfreihafen.org \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linma@zju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).