From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.pengutronix.de ([85.220.165.71]:52863 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731676AbfDQKBK (ORCPT ); Wed, 17 Apr 2019 06:01:10 -0400 Subject: Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling References: <20190416203620.539628-1-arnd@arndb.de> From: Marc Kleine-Budde Message-ID: <4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de> Date: Wed, 17 Apr 2019 11:59:55 +0200 MIME-Version: 1.0 In-Reply-To: <20190416203620.539628-1-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oP6RuXvTEGF9Y54Th4EJnog3EsjFlvu8A" Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Arnd Bergmann , "David S. Miller" , Ralf Baechle , Marcel Holtmann , Johan Hedberg , Oliver Hartkopp , Gerrit Renker , Alexander Aring , Stefan Schmidt , Alexey Kuznetsov , Hideaki YOSHIFUJI , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , Andrew Hendry , Eric Dumazet , Willem de Bruijn , Deepa Dinamani Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, linux-sctp@vger.kernel.org, linux-x25@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oP6RuXvTEGF9Y54Th4EJnog3EsjFlvu8A Content-Type: multipart/mixed; boundary="bhFxmOk9TZicUAH3UPosBJuXCCeMCMkUw"; protected-headers="v1" From: Marc Kleine-Budde To: Arnd Bergmann , "David S. Miller" , Ralf Baechle , Marcel Holtmann , Johan Hedberg , Oliver Hartkopp , Gerrit Renker , Alexander Aring , Stefan Schmidt , Alexey Kuznetsov , Hideaki YOSHIFUJI , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , Andrew Hendry , Eric Dumazet , Willem de Bruijn , Deepa Dinamani Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, linux-sctp@vger.kernel.org, linux-x25@vger.kernel.org Message-ID: <4eabda4b-d08e-ae29-b3df-0971e909fe9c@pengutronix.de> Subject: Re: [PATCH net-next 1/3] net: rework SIOCGSTAMP ioctl handling References: <20190416203620.539628-1-arnd@arndb.de> In-Reply-To: <20190416203620.539628-1-arnd@arndb.de> --bhFxmOk9TZicUAH3UPosBJuXCCeMCMkUw Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 4/16/19 10:32 PM, Arnd Bergmann wrote: > The SIOCGSTAMP/SIOCGSTAMPNS ioctl commands are implemented by many > socket protocol handlers, and all of those end up calling the same > sock_get_timestamp()/sock_get_timestampns() helper functions, which > results in a lot of duplicate code. >=20 > With the introduction of 64-bit time_t on 32-bit architectures, this > gets worse, as we then need four different ioctl commands in each > socket protocol implementation. >=20 > To simplify that, let's add a new .gettstamp() operation in > struct proto_ops, and move ioctl implementation into the common > sock_ioctl()/compat_sock_ioctl_trans() functions that these all go > through. >=20 > We can reuse the sock_get_timestamp() implementation, but generalize > it so it can deal with both native and compat mode, as well as > timeval and timespec structures. >=20 > Acked-by: Stefan Schmidt > Link: https://lore.kernel.org/lkml/CAK8P3a038aDQQotzua_QtKGhq8O9n+rdiz2= =3DWDCp82ys8eUT+A@mail.gmail.com/ > Signed-off-by: Arnd Bergmann For the CAN part: Acked-by: Marc Kleine-Budde regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --bhFxmOk9TZicUAH3UPosBJuXCCeMCMkUw-- --oP6RuXvTEGF9Y54Th4EJnog3EsjFlvu8A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEmvEkXzgOfc881GuFWsYho5HknSAFAly2+RsACgkQWsYho5Hk nSA+5Qf/TdRQd9Jb+CrEOmRTXkDOy+oG5Q4lOH8kTGLGuVcufVKYrWxNazF2WNAU uiohTFCKRBHADN7QSPuJcj5bKF/zAva4tIOEI+P/E/kJKklBF0JwPc676SmkUaop mMat6DD+JbjBkUVVGum0QxcuvTX870gX//xOhwjjEZDwx9nphQ0LJHas6t675WJY /gM4YTaSzuGCMsh65dduYl3d2UG0a1X4S8JtOgoBniszfkJYDxd2TAhZdur/tCq6 C3WtdnLh3NvCFu6Q4HDaBrXqgtv0/n1pX0zko+TNiNv0ETTx8bbHztafQBR/xWIt W2DtCx2TmAr9FxU5oK3tnc5OO9QiFg== =MQJ6 -----END PGP SIGNATURE----- --oP6RuXvTEGF9Y54Th4EJnog3EsjFlvu8A--