Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan - ML <linux-wpan@vger.kernel.org>
Subject: Re: [PATCH rpld 0/6] Mixed bag of rpld patches
Date: Sun, 22 Dec 2019 23:07:10 +0100
Message-ID: <50906bc4-c27b-0f3d-352e-e1b3fd5613b9@datenfreihafen.org> (raw)
In-Reply-To: <CAB_54W5g137YQJRoVUrUF1ELoP_s1SWhocQ2sPLni6moHc4Tdw@mail.gmail.com>

Hello.

On 21.12.19 00:06, Alexander Aring wrote:
> Hi Stefan,
> 
> On Wed, 18 Sep 2019 at 15:58, Stefan Schmidt <stefan@datenfreihafen.org> wrote:
>>
>> Hello.
>>
>> This series does really not have any theme, besides me starting
>> to look into rpld and playing around with it.
>>
>> I had to fix meson for my lua detection and make sure the ifdef
>> for SCOPE_ID is honoured. After getting it all building locally
>> I added Travis support and submitted builds to Coverity.
>> Afterwards I did a quick run through the reports from address
>> sanitizer and coverity scan.
>>
>> Not sure if you would prefer review for rpld as patches here on
>> the list or as pull requests on github. Up to you.
>>
> 
> I can't deal with the github gui! I click always the wrong buttons
> there. Thanks for setting up this travis support, does it work like
> wpan-tools to push it into branch "coverity_scan"?

Yes

> I would like to review patches via mail, what do you prefer? What is
> the procedure when somebody submits pull requests on github then,
> somebody of us send it via mail? Sounds more work... Can we do both as
> "whatever you like"? Can github somehow send pull request via github
> to this mailinglist? Would be nice to have something to connect the
> whole github thing to a mailinglist and you can control it with that
> as well... at least the commenting system but I think this isn't
> possible and the new kids wants all pull request via github gui. We
> didn't answered this question for wpan-tools as well and I once
> clicked the "merge" button (actually not by accident).

I do not mind any of the two methods. Getting Github and mailing lists 
working together is to big of a task on its own for such a small project 
to tackle in my opinion.

Given the low volumes of patches we are seeing on wpan-tools and maybe 
also rpld I would not mind if we say that we accept both ways. Mailing 
patches as well as pull requests. That would ease the contributions for 
some people I hope. And while it puts a bit more burden on us it should 
not be to hard given the low volume.

> 
> Also how we do that with signed off by thing? I can still fix it
> somehow what I did there...

Signed off by makes only sense if we have a document descriping what we 
mean by it. If we want it and use the one from the kernel we need to 
communicate this clearly. If not, the sign offs are off no use.

regards
Stefan Schmidt

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190918195819.7492-1-stefan@datenfreihafen.org>
     [not found] ` <20190918195819.7492-3-stefan@datenfreihafen.org>
2019-12-20 22:52   ` [PATCH rpld 2/6] send: make sure we check on scope id usage Alexander Aring
2019-12-20 23:06 ` [PATCH rpld 0/6] Mixed bag of rpld patches Alexander Aring
2019-12-22 22:07   ` Stefan Schmidt [this message]
2020-01-09 22:38 ` Alexander Aring
2020-01-10  8:54   ` Stefan Schmidt

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50906bc4-c27b-0f3d-352e-e1b3fd5613b9@datenfreihafen.org \
    --to=stefan@datenfreihafen.org \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-WPAN Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
		linux-wpan@vger.kernel.org
	public-inbox-index linux-wpan

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git