Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Koen Zandberg <koen@bergzand.net>,
	Christopher Friedt <chrisfriedt@gmail.com>
Cc: linux-wpan@vger.kernel.org,
	Andrei Emeltchenko <andrei.emeltchenko@intel.com>,
	erik@statropy.com
Subject: Re: wpanusb?
Date: Fri, 24 Jul 2020 15:41:49 +0200
Message-ID: <6d787a84-56ba-2dcf-af5c-6f05cec6194a@datenfreihafen.org> (raw)
In-Reply-To: <0ccbc151-cf8e-cd56-28f8-f1594d226056@bergzand.net>

Hello.

[Added Erik here to be part of the discussion]

This mostly goes to Koen and Erik. Please coordinate how you are wanting 
to work on this. And be pro-active. Waiting for the other one to start 
will just lead to starving :-)


I started to hack together some parts as I would do them. Really not 
working at all right now and only compile tested. I will give more 
details below. I am not sure if I will find time to work more on this 
next week before I go on vacation, so here is what I have:

https://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git/log/?h=wpanusb-original

Feel free to use any of it or ignore it if you have something better.
Really just my take in a really rushed break.

On 05.06.20 13:07, Koen Zandberg wrote:
> Hello
> 
> On 03-06-2020 20:18, Stefan Schmidt wrote:
>> Hello.
>>
>> Happy to see that we finally have the critical mass to get this moved
>> forward. :-)
>>
>> Here is my take on what I think needs to be done.
>>
>> On a first review I found nothing wrong with the design. It needs
>> further extending and flexibility in my opinion, though.
> I would suggest using USB bulk endpoints for both the tx and rx paths.
> An interrupt IN endpoint might be useful for events from the radio back
> to the host such as ack information from a transmit. This way we can
> keep the control messages to configuration only. This is similar to how
> USB ethernet devices are using different USB endpoints. I also see
> issues with transferring large 802.15.4g frames over control endpoints.
> Something similar like CDC-ECM would be my preference here: Split the
> frame in multiple bulk transfers and detect the end of the frame by a
> transfer size not equal to the endpoint size.

For the above I completely ignore the move to bulk. This still needs doing.

>> o Add a GET_EXTENDED_ADDR command to receive the extended address
>> provided by the transceiver itself, or firmware in some way.
> +1

My take on this is in the above branch.

>> o Adding a GET_CAPABILITIES command to query device capabilities
>>   during init to enable and set needed ieee802154_ops based on the
>> device. Given that we aim to support as many transceivers as possible
>> we can't rely on static device knowledge to configure wpanusb correctly.

I started to work on this. The real questions is are we passing all the 
frequency bands and others settings through the USB spec or are we going 
with tables for these inside the firmware and driver and only reference 
them? The later is more efficient the first one is more flexible and 
likely more extensible for future changes.


> Does it make sense to include also a "protocol" version here, to allow
> extending the feature set of the driver later without causing
> compatibility issues between the firmware and the kernel?

How about we are using the USB version part of the descriptor for this? 
We would identify a newer version device not only the spec. The device 
handling could work on both.

>>
>> o Add opcode for set_lbt in USB spec

Added a first take on this.

> This requires some clarification for me how the radio should be
> configured. Is this just a CSMA/CCA switch?
>>
>> o Add opcode for set_frame_retries USB spec. (If a transceiver does
>> not support AutoACK in hardware do Zephyr and RIOT support a software
>> fallback to handle AutoACK?)

Added a first take on this. Needs USB helper functions to handle the 
config data being passed to the device.

> This can be implemented in RIOT. I don't think there is something in
> place at the moment, most of our radios support this in hardware, but I
> see no technical reason why not to support this.
>>
>> o How are we going to handle transceiver which allow MTUs > 127? Not a
>> high priority as the kernel part does not support this either right now.
> There is some preliminary support for 802.15.4g radios in RIOT. I know
> some developers that would prefer not to have to have the MTU limited to
> 127 bytes :)

This is completely ignored for now.

>> o Do Zephyr or RIOT expose additional functionality we should support
>> here?
>>
>> o Koen, you offered to look into implementing the firmware support for
>> the USB spec in RIOT. Does the spec fit what RIOT has as abstraction
>> for ieee802154?
> 
> Yes, implementing configuration settings as USB control messages makes
> glueing them to the radio abstraction layer very easy. For now RIOT has
> configuration for:
> 
>   - reading and writing channel/page settings
>   - read/write to addresses, both long and short
>   - PAN ID
>   - TX power settings
>   - reading the max PSDU size
>   - Ack config settings
>   - CCA and CSMA configuration, enabling/disabling, retries and backoff
> exponent (max/min)
>   - CCA threshold and mode
> 
> Furthermore, it is possible to get frame metadata such as the received
> signal strength and the number of retries required for the frame
> transmit. All these settings depend a bit on the radio hardware features
> of course, but thats what we have the GET_CAPABILITIES for.

If I have time to do more work on this I will update you folks. As I 
wrote above. Read over it and feel free to use any of the above or 
implement it yourself.

Looking forward to the progress on this when back from my vacation. :-)

regards
Stefan Schmidt

      parent reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 12:39 wpanusb? Christopher Friedt
2020-05-26 19:38 ` wpanusb? Stefan Schmidt
2020-05-29 19:33   ` wpanusb? Christopher Friedt
2020-05-30 11:33     ` wpanusb? Stefan Schmidt
2020-05-30 15:08       ` wpanusb? Christopher Friedt
2020-05-30 18:10         ` wpanusb? Koen Zandberg
2020-05-31 16:13           ` wpanusb? Christopher Friedt
2020-06-03 18:18             ` wpanusb? Stefan Schmidt
2020-06-05 11:07               ` wpanusb? Koen Zandberg
2020-06-07 12:17                 ` wpanusb? Stefan Schmidt
2020-07-06 14:42                   ` wpanusb? Stefan Schmidt
     [not found]                     ` <CAF4BF-TdLpg6hCc8iiR40tGmV9C5EPDF6c6Qr5m5CfDWOVJUMA@mail.gmail.com>
2020-07-23  8:15                       ` wpanusb? Stefan Schmidt
2020-07-24 13:26                       ` wpanusb? Stefan Schmidt
2020-07-24 13:41                 ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d787a84-56ba-2dcf-af5c-6f05cec6194a@datenfreihafen.org \
    --to=stefan@datenfreihafen.org \
    --cc=andrei.emeltchenko@intel.com \
    --cc=chrisfriedt@gmail.com \
    --cc=erik@statropy.com \
    --cc=koen@bergzand.net \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-WPAN Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
		linux-wpan@vger.kernel.org
	public-inbox-index linux-wpan

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git