* [PATCH] ieee802154:: propagate genlmsg_reply return code
@ 2019-02-19 5:10 Li RongQing
2019-02-26 20:34 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Li RongQing @ 2019-02-19 5:10 UTC (permalink / raw)
To: linux-wpan
genlmsg_reply can fail, so propagate its return code
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
drivers/net/ieee802154/mac802154_hwsim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index b6743f03dce0..3b88846de31b 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -324,7 +324,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info)
goto out_err;
}
- genlmsg_reply(skb, info);
+ res = genlmsg_reply(skb, info);
break;
}
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ieee802154:: propagate genlmsg_reply return code
2019-02-19 5:10 [PATCH] ieee802154:: propagate genlmsg_reply return code Li RongQing
@ 2019-02-26 20:34 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2019-02-26 20:34 UTC (permalink / raw)
To: Li RongQing, linux-wpan
Hello Li.
On 19.02.19 06:10, Li RongQing wrote:
> genlmsg_reply can fail, so propagate its return code
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/net/ieee802154/mac802154_hwsim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index b6743f03dce0..3b88846de31b 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -324,7 +324,7 @@ static int hwsim_get_radio_nl(struct sk_buff *msg, struct genl_info *info)
> goto out_err;
> }
>
> - genlmsg_reply(skb, info);
> + res = genlmsg_reply(skb, info);
> break;
> }
>
>
I would prefer the subject line to also include the part the patch
applies to, in this case the hwsim driver. In my book that is easier to
grasp. But it is a nitpick really and I fixed it up for you when
applying. New subject line is:
ieee802154: hwsim: propagate genlmsg_reply return code
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19 5:10 [PATCH] ieee802154:: propagate genlmsg_reply return code Li RongQing
2019-02-26 20:34 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).