Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan - ML <linux-wpan@vger.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs
Date: Sun, 28 Feb 2021 22:16:38 -0500
Message-ID: <CAB_54W4Lo7TKnqWm_xH=SncTYXTrvT3JCGxTNamagPQ4e0Vs0g@mail.gmail.com> (raw)
In-Reply-To: <20210228151817.95700-3-aahringo@redhat.com>

Hi Stefan,

On Sun, 28 Feb 2021 at 10:21, Alexander Aring <aahringo@redhat.com> wrote:
>
> This patch adds a missing consume_skb() when deliver a skb to upper
> monitor interfaces of a wpan phy.
>
> Reported-by: syzbot+44b651863a17760a893b@syzkaller.appspotmail.com
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>  net/mac802154/rx.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
> index b8ce84618a55..18abc1f49323 100644
> --- a/net/mac802154/rx.c
> +++ b/net/mac802154/rx.c
> @@ -244,6 +244,8 @@ ieee802154_monitors_rx(struct ieee802154_local *local, struct sk_buff *skb)
>                         sdata->dev->stats.rx_bytes += skb->len;
>                 }
>         }
> +
> +       consume_skb(skb);

Please drop this patch. It's not correct. I will look next weekend at
this one again.
The other patches should be fine, I hope.

- Alex

  reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 15:18 [PATCH wpan 00/17] ieee802154: syzbot fixes Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned Alexander Aring
2021-03-02 21:18   ` Stefan Schmidt
2021-03-06 23:35     ` Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs Alexander Aring
2021-03-01  3:16   ` Alexander Aring [this message]
2021-03-02 12:43     ` Stefan Schmidt
2021-02-28 15:18 ` [PATCH wpan 03/17] net: ieee802154: nl-mac: fix check on panid Alexander Aring
2021-03-02 21:33   ` Stefan Schmidt
2021-02-28 15:18 ` [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params Alexander Aring
2021-03-02 21:45   ` Stefan Schmidt
2021-03-06 13:12     ` Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 05/17] net: ieee802154: stop dump llsec keys for monitors Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 06/17] net: ieee802154: forbid monitor for add llsec key Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 07/17] net: ieee802154: forbid monitor for del " Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 08/17] net: ieee802154: stop dump llsec devs for monitors Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 09/17] net: ieee802154: forbid monitor for add llsec dev Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 10/17] net: ieee802154: forbid monitor for del " Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 11/17] net: ieee802154: stop dump llsec devkeys for monitors Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 12/17] net: ieee802154: forbid monitor for add llsec devkey Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 13/17] net: ieee802154: forbid monitor for del " Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 14/17] net: ieee802154: stop dump llsec seclevels for monitors Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 15/17] net: ieee802154: forbid monitor for add llsec seclevel Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 16/17] net: ieee802154: forbid monitor for del " Alexander Aring
2021-02-28 15:18 ` [PATCH wpan 17/17] net: ieee802154: stop dump llsec params for monitors Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB_54W4Lo7TKnqWm_xH=SncTYXTrvT3JCGxTNamagPQ4e0Vs0g@mail.gmail.com' \
    --to=alex.aring@gmail.com \
    --cc=aahringo@redhat.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-WPAN Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
		linux-wpan@vger.kernel.org
	public-inbox-index linux-wpan

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git