From: Alexander Aring <alex.aring@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wpan - ML <linux-wpan@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
syzbot+12cf5fbfdeba210a89dd@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: mac802154: Fix null pointer dereference
Date: Thu, 4 Mar 2021 09:22:47 -0500 [thread overview]
Message-ID: <CAB_54W7v1Dk9KjytfO8hAGfiqPJ6qO0SdgwDQ-s4ybA2yvuoCg@mail.gmail.com> (raw)
In-Reply-To: <e70d7b45638db427be978c620475a330cb9db57c.camel@gmail.com>
Hi,
On Thu, 4 Mar 2021 at 04:23, Pavel Skripkin <paskripkin@gmail.com> wrote:
...
> >
> > I think this need to be:
> >
> > if (!IS_ERR_OR_NULL(key->tfm[i]))
> >
> > otherwise we still run into issues for the current iterator when
> > key->tfm[i] is in range of IS_ERR().
>
> Oh... I got it completly wrong, I'm sorry. If it's still not fixed,
> I'll send rigth patch for that.
>
please resend your patch. We will review again.
- Alex
next prev parent reply other threads:[~2021-03-04 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 16:27 [PATCH] net: mac802154: Fix null pointer dereference Pavel Skripkin
2021-03-04 2:40 ` Alexander Aring
2021-03-04 9:23 ` Pavel Skripkin
2021-03-04 14:22 ` Alexander Aring [this message]
2021-03-04 15:21 ` [PATCH v2] net: mac802154: Fix general protection fault Pavel Skripkin
2021-03-08 8:27 ` Stefan Schmidt
2021-04-05 0:43 ` Alexander Aring
2021-04-05 5:45 ` Pavel Skripkin
2021-04-05 11:50 ` Alexander Aring
2021-04-06 20:43 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB_54W7v1Dk9KjytfO8hAGfiqPJ6qO0SdgwDQ-s4ybA2yvuoCg@mail.gmail.com \
--to=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=stefan@datenfreihafen.org \
--cc=syzbot+12cf5fbfdeba210a89dd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).