From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42DCC433E0 for ; Thu, 4 Mar 2021 14:24:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9877064F23 for ; Thu, 4 Mar 2021 14:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233987AbhCDOXr (ORCPT ); Thu, 4 Mar 2021 09:23:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240834AbhCDOXj (ORCPT ); Thu, 4 Mar 2021 09:23:39 -0500 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D1E4C061574; Thu, 4 Mar 2021 06:22:59 -0800 (PST) Received: by mail-oi1-x236.google.com with SMTP id i21so27981769oii.2; Thu, 04 Mar 2021 06:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6git8wNlDsSLDjVUii3CBUd0Th3PWz6n9wOTfDK7YLc=; b=PyZYbk/K2HbO11rQADvYx7sTXh1bBbEWei72K/0itzsP18fthwPDI2pKdDsMfCZmxI GW77b2Cal6U1hXniKwHOFUjdilZ2X1DPR8crq2zfd69cAXNBLhFT9RXGI/92W0IS4CNF lZ1uo2nHXo2waoRFhTBOTR2MUC4fw7sWAAA6vj6LHuGgw1KS2ODMSZ+9P3130+11WsKk UclHf2MkX5YSXZNXBykQeapSGmCNY9qQCA5yXI2JZrbT38xYmQJvG/1DkwRQWE6C9wH1 UxzcaE+xenuTlGr+hTXP3EBYsQVbFFk7pjQq8hJmQ7emGNEsCdwESNFVw1pSEFj++EZ3 kcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6git8wNlDsSLDjVUii3CBUd0Th3PWz6n9wOTfDK7YLc=; b=Hf0w4mbHvs4FZ/UTUJuxvTK4fQWsVLT9XFMPFFsgNwAymRp/0cELD3Qb/vpLGloq1k ngrFWkhW8b0UF1RwiF7Vr8WOXxGPNiLXXoijq+GubPr7UiPpESaLyv8uGZVIcsjBI05V LZGbthmHeWW1pPp3QR6VnHxR+9WCjlvEqnBhlIPVBAJJNXTiSW12Qqx+bMU8Mt/3lKq9 z2V6GEupMczhrsisjjMQg7yrsmRXyQXvtnsigfp5SD0816CO0WozHjLCUaKTQ4PrRKVs E1TOZgG3IInp+U8Cf6rqoYtmyhCJoKkcapVKhL4oJfzqUqplPCVeiIPRq5Z/hjnc2+gm 09ZQ== X-Gm-Message-State: AOAM531kvq+ohe3FltqFqtk2xpI9DPtYxDYoNqNtqaMCNrgu5GzH0bbg oqM0bMqMrOBmvTUhwictPSAWnhNK9USIHCTIGNc= X-Google-Smtp-Source: ABdhPJza6KqKND0SPEifCF8m8ht1WDfQzuBen506UAZXyTCDAUig/3hwvnLXFwAD9m0HiOQzLMAR1+OGbypVjsECUJk= X-Received: by 2002:aca:3d85:: with SMTP id k127mr3251418oia.157.1614867778829; Thu, 04 Mar 2021 06:22:58 -0800 (PST) MIME-Version: 1.0 References: <20210303162757.763502-1-paskripkin@gmail.com> In-Reply-To: From: Alexander Aring Date: Thu, 4 Mar 2021 09:22:47 -0500 Message-ID: Subject: Re: [PATCH] net: mac802154: Fix null pointer dereference To: Pavel Skripkin Cc: Stefan Schmidt , "David S. Miller" , linux-wpan - ML , "open list:NETWORKING [GENERAL]" , kernel list , syzbot+12cf5fbfdeba210a89dd@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org Hi, On Thu, 4 Mar 2021 at 04:23, Pavel Skripkin wrote: ... > > > > I think this need to be: > > > > if (!IS_ERR_OR_NULL(key->tfm[i])) > > > > otherwise we still run into issues for the current iterator when > > key->tfm[i] is in range of IS_ERR(). > > Oh... I got it completly wrong, I'm sorry. If it's still not fixed, > I'll send rigth patch for that. > please resend your patch. We will review again. - Alex