From: Alexander Aring <aahringo@redhat.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan - ML <linux-wpan@vger.kernel.org>,
David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH wpan-next v3 10/11] net: mac802154: Add a warning in the hot path
Date: Tue, 17 May 2022 20:58:19 -0400 [thread overview]
Message-ID: <CAK-6q+g=9_aqTOmMYxCn6p=Z=uPNyifjVXe4hzC82ZF1QPpLMg@mail.gmail.com> (raw)
In-Reply-To: <20220517163450.240299-11-miquel.raynal@bootlin.com>
Hi,
On Tue, May 17, 2022 at 12:35 PM Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
>
> We should never start a transmission after the queue has been stopped.
>
> But because it might work we don't kill the function here but rather
> warn loudly the user that something is wrong.
>
> Set an atomic when the queue will remain stopped. Reset this atomic when
> the queue actually gets restarded. Just check this atomic to know if the
> transmission is legitimate, warn if it is not.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> include/net/cfg802154.h | 1 +
> net/mac802154/tx.c | 16 +++++++++++++++-
> net/mac802154/util.c | 1 +
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> index 8881b6126b58..f4e7b3fe7cf0 100644
> --- a/include/net/cfg802154.h
> +++ b/include/net/cfg802154.h
> @@ -218,6 +218,7 @@ struct wpan_phy {
> spinlock_t queue_lock;
> atomic_t ongoing_txs;
> atomic_t hold_txs;
> + unsigned long queue_stopped;
Can we name it something like state_flags (as phy state flags)? Pretty
sure there will be more coming, or internal_flags, no idea...
something_flags...
> wait_queue_head_t sync_txq;
>
> char priv[] __aligned(NETDEV_ALIGN);
> diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
> index 6cc4e5c7ba94..e36aca788ea2 100644
> --- a/net/mac802154/tx.c
> +++ b/net/mac802154/tx.c
> @@ -123,9 +123,13 @@ static int ieee802154_sync_queue(struct ieee802154_local *local)
>
> int ieee802154_sync_and_hold_queue(struct ieee802154_local *local)
> {
> + int ret;
> +
> ieee802154_hold_queue(local);
> + ret = ieee802154_sync_queue(local);
> + set_bit(0, &local->phy->queue_stopped);
>
Define the 0 as WPAN_PHY_STATE_QUEUE_STOPPED_BIT or something like
that, above wpan_phy.
- Alex
next prev parent reply other threads:[~2022-05-18 0:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 16:34 [PATCH wpan-next v3 00/11] ieee802154: Synchronous Tx support Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 01/11] net: mac802154: Rename the synchronous xmit worker Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 02/11] net: mac802154: Rename the main tx_work struct Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 03/11] net: mac802154: Enhance the error path in the main tx helper Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 04/11] net: mac802154: Follow the count of ongoing transmissions Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 05/11] net: mac802154: Bring the ability to hold the transmit queue Miquel Raynal
2022-05-18 0:37 ` Alexander Aring
2022-05-18 8:26 ` Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 06/11] net: mac802154: Create a hot tx path Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 07/11] net: mac802154: Introduce a helper to disable the queue Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 08/11] net: mac802154: Introduce a tx queue flushing mechanism Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 09/11] net: mac802154: Introduce a synchronous API for MLME commands Miquel Raynal
2022-05-18 0:41 ` Alexander Aring
2022-05-18 8:44 ` Miquel Raynal
2022-05-18 11:59 ` Alexander Aring
2022-05-18 12:12 ` Alexander Aring
2022-05-18 12:44 ` Miquel Raynal
2022-05-18 13:02 ` Alexander Aring
2022-05-17 16:34 ` [PATCH wpan-next v3 10/11] net: mac802154: Add a warning in the hot path Miquel Raynal
2022-05-18 0:58 ` Alexander Aring [this message]
2022-05-18 8:55 ` Miquel Raynal
2022-05-18 14:31 ` Alexander Aring
2022-05-18 16:29 ` Miquel Raynal
2022-05-19 1:52 ` Alexander Aring
2022-05-17 16:34 ` [PATCH wpan-next v3 11/11] net: mac802154: Add a warning in the slow path Miquel Raynal
2022-05-18 0:52 ` Alexander Aring
2022-05-18 9:37 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK-6q+g=9_aqTOmMYxCn6p=Z=uPNyifjVXe4hzC82ZF1QPpLMg@mail.gmail.com' \
--to=aahringo@redhat.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=frederic.blain@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=pabeni@redhat.com \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).