From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963CBECAAD4 for ; Sat, 3 Sep 2022 19:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231753AbiICTKV (ORCPT ); Sat, 3 Sep 2022 15:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiICTKU (ORCPT ); Sat, 3 Sep 2022 15:10:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A87C3F30F for ; Sat, 3 Sep 2022 12:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662232216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZK7kW7g3nA/IMsZ748NoWytpPXrK/3y9tfwwIoIKLoA=; b=J3YPcg8KqqfIThLcMnJxGpyw7BCvsnjJsMNAHGyecPA1II/KXQLSaJhyMz7gsk2j3x8p8W flQx53g6qth53g283OlznHbS7ZHY69V6okN+vbdb2GvC2X8YZINeFWP5whzrlXPP0uVFtX JCn9lkOcVdd5AIrtieB55Ck+o0Gr1Tg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-KFZvXdusN3i1XbAtc8hkWA-1; Sat, 03 Sep 2022 15:10:15 -0400 X-MC-Unique: KFZvXdusN3i1XbAtc8hkWA-1 Received: by mail-qt1-f200.google.com with SMTP id fy12-20020a05622a5a0c00b00344569022f7so3980382qtb.17 for ; Sat, 03 Sep 2022 12:10:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZK7kW7g3nA/IMsZ748NoWytpPXrK/3y9tfwwIoIKLoA=; b=q5GdjLnlU11L8q4AbEiQchCoDyLnqZUlBElHzJBn7jC5I/A1kOYZNAg1gjci4OdyQY cLUjO3yfjx+mMZNv6TIfQ4Yvc7bYb31nLj3VjIj7od8yDshiR/3DRuClWVQIEzNQoKtu fOiqWRVScJagdmzfYLv4vkoSusKa49FstDIQf6PjIQjpV3aMjZn0WRKp096lOpKr8oKr h9vBBzfIOUNUUFYBXkDGBA8rycZpL6ujZKDftq4r90iOUi+Pf9BU65bn70srKQMXTyHB LvgLS4LfoulLr8XiXbSXcO/g9K/oDdHjJcQqMRyAh/CCyCQ60QmSHvZ6XiOuRskifxCj 9dUw== X-Gm-Message-State: ACgBeo2MAaQTcvmz1jGpakV8wRU4jUdq0zdviqX95cO5QIzvKur8Oqdk U85pOLH3hUdtie/WBrJYUkkDin6ExKe7K3T1eoXgMSRLoJf3xqC4utqG9ia1zKIOdr3IIW5Yaa8 j1cXV6Z3Qq31HpD5bSKAw6xQJ7507p2XB+gVoNw== X-Received: by 2002:a37:a02:0:b0:6bb:17af:a8e6 with SMTP id 2-20020a370a02000000b006bb17afa8e6mr27233744qkk.80.1662232214957; Sat, 03 Sep 2022 12:10:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR435Cns1uVn6933JwLlcyP7VA8SmkopDyP3EawLba6isjFyHIz1Ze0Uaw9PMAboWgNvclY0EDXLfW0ecvNy2ns= X-Received: by 2002:a37:a02:0:b0:6bb:17af:a8e6 with SMTP id 2-20020a370a02000000b006bb17afa8e6mr27233730qkk.80.1662232214757; Sat, 03 Sep 2022 12:10:14 -0700 (PDT) MIME-Version: 1.0 References: <20220701143052.1267509-1-miquel.raynal@bootlin.com> <20220823182950.1c722e13@xps-13> <20220824122058.1c46e09a@xps-13> <20220824152648.4bfb9a89@xps-13> <20220825145831.1105cb54@xps-13> <20220826095408.706438c2@xps-13> <20220829100214.3c6dad63@xps-13> <20220831173903.1a980653@xps-13> <20220901020918.2a15a8f9@xps-13> <20220901150917.5246c2d0@xps-13> <20220903020829.67db0af8@xps-13> <20220903180556.6430194b@xps-13> In-Reply-To: From: Alexander Aring Date: Sat, 3 Sep 2022 15:10:03 -0400 Message-ID: Subject: Re: [PATCH wpan-next 01/20] net: mac802154: Allow the creation of coordinator interfaces To: Miquel Raynal Cc: Alexander Aring , Stefan Schmidt , linux-wpan - ML , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Network Development , David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Thomas Petazzoni , werner@almesberger.net Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org On Sat, Sep 3, 2022 at 3:07 PM Alexander Aring wrote: > > Hi, > > On Sat, Sep 3, 2022 at 12:06 PM Miquel Raynal wrote: > ... > > > > On the Tx side, when sending eg. an association request or an > > association response, I must expect and wait for an ack. This is > > what I am struggling to do. How can I know that a frame which I just > > transmitted has been acked? Bonus points, how can I do that in such a > > way that it will work with other devices? (hints below) > > > > > AACK will send a back if a frame with ack request bit was received. > > > > > > > say in a commit) I have seen no further updates about it so I guess > > > > it's still not available. I don't see any other way to know if a > > > > frame's ack has been received or not reliably. > > > > > > You implemented it for the at86rf230 driver (the spi one which is what > > > also atusb uses). You implemented the > > > > > > ctx->trac = IEEE802154_NO_ACK; > > > > > > which signals the upper layer that if the ack request bit is set, that > > > there was no ack. > > > > > > But yea, there is a missing feature for atusb yet which requires > > > firmware changes as well. > > > > :'( > > There is a sequence handling in tx done on atusb firmware and I think > it should be pretty easy to add a byte for trac status. > > diff --git a/atusb/fw/mac.c b/atusb/fw/mac.c > index 835002c..156bd95 100644 > --- a/atusb/fw/mac.c > +++ b/atusb/fw/mac.c > @@ -116,7 +116,7 @@ static void receive_frame(void) > > static bool handle_irq(void) > { > - uint8_t irq; > + uint8_t irq, data[2]; > > irq = reg_read(REG_IRQ_STATUS); > if (!(irq & IRQ_TRX_END)) > @@ -124,7 +124,15 @@ static bool handle_irq(void) > > if (txing) { > if (eps[1].state == EP_IDLE) { > - usb_send(&eps[1], &this_seq, 1, tx_ack_done, NULL); > + data[0] = tx_ack_done; > + > + spi_begin(); > + spi_io(REG_TRX_STATE); > + > + data[1] = spi_recv(); > + spi_end(); data[1] = reg_read(REG_TRX_STATE) as seen above for REG_IRQ_STATUS would be better here... - Alex