From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7488DC00144 for ; Mon, 1 Aug 2022 23:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234866AbiHAXmY (ORCPT ); Mon, 1 Aug 2022 19:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233235AbiHAXmX (ORCPT ); Mon, 1 Aug 2022 19:42:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A6CD94333C for ; Mon, 1 Aug 2022 16:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659397341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0oRGguOnPX0TTD163ZhfwgVWeLoIzqDnSSNj+nC26Y=; b=CZ5DNDtBRYD3MXiF5PF300sdV3kixfFwQ9CJjOBKEIgOmsehdz+wQULzFZoh0znS5+404e PBte8CvkfTzoDRph6K6kc9Vjf8vLxe08kOfvAUVfUUnEzS9n9HOlReU2V7UbJ578O+2kVf AMztQ0yvR+c5Prf6NrmSwaAdzTSHyeg= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547--DA7KowQN1eJgyo7_coJHw-1; Mon, 01 Aug 2022 19:42:20 -0400 X-MC-Unique: -DA7KowQN1eJgyo7_coJHw-1 Received: by mail-qv1-f72.google.com with SMTP id dn2-20020a056214094200b0047491ead6a2so4979328qvb.2 for ; Mon, 01 Aug 2022 16:42:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=Q0oRGguOnPX0TTD163ZhfwgVWeLoIzqDnSSNj+nC26Y=; b=oOV17UZ1nGNtgm4npBlsN7nRE4ZT8qmX0AupuNwmwg16WktmPqz8/UbCjkxv5pOo4x r15YB1aNrfhp2YWWvcUNwccX8LS75zUcMpOqgGNX/RwMGtQiUr5d21sDQCj4fwzivOwk kqUIrejpLaZUBLoji7q+TewX+8KBbEiDVJzLdArodLwQ649gIPLD7cx6L0a6EtP1F4mm yiKD5DXp9PApD/OM1fECYFvo0vosDSS5xEV4v7IJKNHVTdsizEYJqJRFLYmdf+4acfnW GhcdMyILvuc6rDPGhBpNO637zDwOG8upltwdr+4oaOwDaEzNX69GWVLsrS2rwK3Syed8 lJEA== X-Gm-Message-State: AJIora/kd7wGqn5+jof0WJ4AMvbjJz13q8DMqkE8itPBSo7y+sVq+Q5V 32lxatrSG7+zhkMH3I6F0fwVgSKxzIxTNT4VcdEK90jC0SZpBK9ti+np00iuDpP3SBUgooXDP8f bo9nUzSu74r8jifQLlHi/OuPmQBSOAWz7x2F7dw== X-Received: by 2002:a05:622a:1316:b0:31e:f3b4:1c8c with SMTP id v22-20020a05622a131600b0031ef3b41c8cmr16744828qtk.339.1659397339376; Mon, 01 Aug 2022 16:42:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vbJZYXyRcJEnyF8L4b8tDvLVv1K5QQlmIoeGtEOq3JCHbn87oxy5Y5VfkMJ6pOzSSWXmUh01hemlWPmn4UfTI= X-Received: by 2002:a05:622a:1316:b0:31e:f3b4:1c8c with SMTP id v22-20020a05622a131600b0031ef3b41c8cmr16744813qtk.339.1659397339079; Mon, 01 Aug 2022 16:42:19 -0700 (PDT) MIME-Version: 1.0 References: <20220701143052.1267509-1-miquel.raynal@bootlin.com> <20220701143052.1267509-11-miquel.raynal@bootlin.com> In-Reply-To: From: Alexander Aring Date: Mon, 1 Aug 2022 19:42:08 -0400 Message-ID: Subject: Re: [PATCH wpan-next 10/20] net: mac802154: Handle passive scanning To: Miquel Raynal Cc: Alexander Aring , Stefan Schmidt , linux-wpan - ML , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Network Development , David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org Hi, On Thu, Jul 14, 2022 at 11:33 PM Alexander Aring wrote: ... > > I know some driver datasheets and as I said before, it's not allowed > to set promiscuous mode while in receive mode. We need to stop tx, > what we are doing. Then call stop() driver callback, > synchronize_net(), mac802154_set_promiscuous_mode(...), start(). The > same always for the opposite. > I think we should try to work on that as a next patch series to offer such functionality in which "filtering level" the hardware should be "started". As I said it cannot be changed during runtime as "transceiver is being in receive mode" but there is the possibility to stop/start the hardware _transparent_ from the user to change the "filtering level". I say filtering level because I think this is what the standard uses as a term. The one which is needed here is promiscuous mode, otherwise yea we usually use the highest filtering level. When changing the "filtering level" it depends on interface type what we need to filter in softmac then and what's not. One thing in promiscuous mode and everything else than monitor is to check on if the checksum is valid and drop if necessary, same for address filtering, etc. I don't assume that the software filtering is 100% correct, but we should have a basis to adding more filters if necessary and we found something is missing? What do you think? - Alex