linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: werner@almesberger.net,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	Alexander Aring <alex.aring@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-wpan - ML <linux-wpan@vger.kernel.org>
Subject: Re: [PATCH atusb/fw 2/2] atusb: fw: Provide TRAC status
Date: Mon, 5 Sep 2022 20:19:28 -0400	[thread overview]
Message-ID: <CAK-6q+jdrk+5STNapcb=WX3vi8T-ucMSj3KDi8yB2WjGd93moQ@mail.gmail.com> (raw)
In-Reply-To: <CAK-6q+jXWgEbZ_2kyOh-Jh4N1+d6owMbRn0e637MPMt+3+779g@mail.gmail.com>

Hi,

On Mon, Sep 5, 2022 at 8:16 PM Alexander Aring <aahringo@redhat.com> wrote:
>
> Hi,
>
> On Mon, Sep 5, 2022 at 4:43 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > From: Alexander Aring <aahringo@redhat.com>
> >
> > Upon Tx done condition, returning the sequence number is useful but we
> > might also return the TRAC value which is needed to ensure that the
> > packet we sent got ACKed. The TRAC register just needs to be read when
> > the TRX_END interrupt fires.
> >
> > We then need to send this information as part of the status
> > message. First byte remains the sequence number for ensuring backward
> > compatibility and a second byte is added to forward the TRAC register
> > status.
> >
> > Signed-off-by: Alexander Aring <aahringo@redhat.com>
> > [Miquel Raynal: Moved the data array out of the stack, wrote commit log]
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> I sent another patch v2, it should also fix a race see commit msg
> regarding RX_AACK_ON. May you can fast test it and feel welcome to
> resubmit it as a patch.
> This patch has a lot of generated/compiled files added and I think it
> was an accident.

there are files which need to be added to ".gitignore". Just a hint,
run "git add -u ." instead of "git add ." which will not add new
files.

- Alex


  reply	other threads:[~2022-09-06  0:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 20:43 [PATCH atusb/fw 1/2] atusb: fw: Update toolchain instructions Miquel Raynal
2022-09-05 20:43 ` [PATCH atusb/fw 2/2] atusb: fw: Provide TRAC status Miquel Raynal
2022-09-06  0:16   ` Alexander Aring
2022-09-06  0:19     ` Alexander Aring [this message]
2022-09-06  8:08       ` Miquel Raynal
2022-09-05 23:33 ` [PATCH atusb/fw 1/2] atusb: fw: Update toolchain instructions Alexander Aring
2022-09-06  7:56   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK-6q+jdrk+5STNapcb=WX3vi8T-ucMSj3KDi8yB2WjGd93moQ@mail.gmail.com' \
    --to=aahringo@redhat.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=werner@almesberger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).