From: Stefan Schmidt <stefan@datenfreihafen.org>
To: YueHaibing <yuehaibing@huawei.com>,
varkabhadram@gmail.com, alex.aring@gmail.com,
davem@davemloft.net
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] ieee802154: remove set but not used variable 'status'
Date: Fri, 25 Oct 2019 06:37:33 +0200 [thread overview]
Message-ID: <aadfdcc0-06df-5c17-dc14-11d54ac8b65f@datenfreihafen.org> (raw)
In-Reply-To: <20191023070618.30044-1-yuehaibing@huawei.com>
Hello.
On 23.10.19 09:06, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ieee802154/cc2520.c:221:5: warning:
> variable status set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ieee802154/cc2520.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index 4350694..89c046b 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -218,7 +218,6 @@ static int
> cc2520_cmd_strobe(struct cc2520_private *priv, u8 cmd)
> {
> int ret;
> - u8 status = 0xff;
> struct spi_message msg;
> struct spi_transfer xfer = {
> .len = 0,
> @@ -236,8 +235,6 @@ cc2520_cmd_strobe(struct cc2520_private *priv, u8 cmd)
> priv->buf[0]);
>
> ret = spi_sync(priv->spi, &msg);
> - if (!ret)
> - status = priv->buf[0];
> dev_vdbg(&priv->spi->dev,
> "buf[0] = %02x\n", priv->buf[0]);
> mutex_unlock(&priv->buffer_mutex);
>
Applied to wpan-next. Thanks!
regards
Stefan Schmidt
prev parent reply other threads:[~2019-10-25 4:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 7:06 [PATCH net-next] ieee802154: remove set but not used variable 'status' YueHaibing
2019-10-24 22:19 ` David Miller
2019-10-25 4:38 ` Stefan Schmidt
2019-10-25 4:37 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aadfdcc0-06df-5c17-dc14-11d54ac8b65f@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=varkabhadram@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).