From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxima.lasnet.de ([78.47.171.185]:38482 "EHLO proxima.lasnet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfCMJJE (ORCPT ); Wed, 13 Mar 2019 05:09:04 -0400 Subject: Re: [PATCH] net: ieee802154: fix a potential NULL pointer dereference References: <20190311072517.29740-1-kjlu@umn.edu> From: Stefan Schmidt Message-ID: Date: Wed, 13 Mar 2019 10:09:02 +0100 MIME-Version: 1.0 In-Reply-To: <20190311072517.29740-1-kjlu@umn.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Kangjie Lu Cc: pakki001@umn.edu, Michael Hennerich , Alexander Aring , "David S. Miller" , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello. On 11.03.19 08:25, Kangjie Lu wrote: > In case alloc_ordered_workqueue fails, the fix releases > sources and returns -ENOMEM to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > --- > drivers/net/ieee802154/adf7242.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > index cd1d8faccca5..cd6b95e673a5 100644 > --- a/drivers/net/ieee802154/adf7242.c > +++ b/drivers/net/ieee802154/adf7242.c > @@ -1268,6 +1268,10 @@ static int adf7242_probe(struct spi_device *spi) > INIT_DELAYED_WORK(&lp->work, adf7242_rx_cal_work); > lp->wqueue = alloc_ordered_workqueue(dev_name(&spi->dev), > WQ_MEM_RECLAIM); > + if (unlikely(!lp->wqueue)) { > + ret = -ENOMEM; > + goto err_hw_init; > + } > > ret = adf7242_hw_init(lp); > if (ret) >