Linux-WPAN Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] ieee802154: ca8210: prevent memory leak
       [not found] <20190917224713.26371-1-navid.emamdoost@gmail.com>
@ 2019-09-27 20:01 ` Stefan Schmidt
  0 siblings, 0 replies; only message in thread
From: Stefan Schmidt @ 2019-09-27 20:01 UTC (permalink / raw)
  To: Navid Emamdoost
  Cc: emamd001, smccaman, kjlu, Harry Morris, Alexander Aring,
	David S. Miller, linux-wpan, netdev, linux-kernel

Hello.

On 18.09.19 00:47, Navid Emamdoost wrote:
> In ca8210_probe the allocated pdata needs to be assigned to
> spi_device->dev.platform_data before calling ca8210_get_platform_data.
> Othrwise when ca8210_get_platform_data fails pdata cannot be released.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
>   drivers/net/ieee802154/ca8210.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index b188fce3f641..229d70a897ca 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -3152,12 +3152,12 @@ static int ca8210_probe(struct spi_device *spi_device)
>   		goto error;
>   	}
>   
> +	priv->spi->dev.platform_data = pdata;
>   	ret = ca8210_get_platform_data(priv->spi, pdata);
>   	if (ret) {
>   		dev_crit(&spi_device->dev, "ca8210_get_platform_data failed\n");
>   		goto error;
>   	}
> -	priv->spi->dev.platform_data = pdata;
>   
>   	ret = ca8210_dev_com_init(priv);
>   	if (ret) {
> 

As Harry seems to be unavailable I am taking this patch directly.


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190917224713.26371-1-navid.emamdoost@gmail.com>
2019-09-27 20:01 ` [PATCH] ieee802154: ca8210: prevent memory leak Stefan Schmidt

Linux-WPAN Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wpan/0 linux-wpan/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wpan linux-wpan/ https://lore.kernel.org/linux-wpan \
		linux-wpan@vger.kernel.org
	public-inbox-index linux-wpan

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wpan


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git