From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxima.lasnet.de ([78.47.171.185]:59627 "EHLO proxima.lasnet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729324AbeLSNd3 (ORCPT ); Wed, 19 Dec 2018 08:33:29 -0500 Subject: Re: [PATCH 2/2] examples: fix wrongly used unsigned attribute References: <20181206202602.22176-1-stefan@datenfreihafen.org> <20181206202602.22176-2-stefan@datenfreihafen.org> From: Stefan Schmidt Message-ID: Date: Wed, 19 Dec 2018 14:33:26 +0100 MIME-Version: 1.0 In-Reply-To: <20181206202602.22176-2-stefan@datenfreihafen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: linux-wpan@vger.kernel.org Cc: aring@mojatatu.com Hello. On 06.12.18 21:26, Stefan Schmidt wrote: > We are passing this buffer into sprintf later which > expects signed. Its a constant string anyway, so > it does not matter for us. Fixes -Wpointer-sign values > spotted by our CI system. > > Signed-off-by: Stefan Schmidt > --- > examples/af_ieee802154_tx.c | 2 +- > examples/af_inet6_tx.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/af_ieee802154_tx.c b/examples/af_ieee802154_tx.c > index e85a109..faad17e 100644 > --- a/examples/af_ieee802154_tx.c > +++ b/examples/af_ieee802154_tx.c > @@ -55,7 +55,7 @@ int main(int argc, char *argv[]) { > int sd; > ssize_t len; > struct sockaddr_ieee802154 dst; > - unsigned char buf[MAX_PACKET_LEN + 1]; > + char buf[MAX_PACKET_LEN + 1]; > /* IEEE 802.15.4 extended send address, adapt to your setup */ > uint8_t long_addr[IEEE802154_ADDR_LEN] = {0xd6, 0x55, 0x2c, 0xd6, 0xe4, 0x1c, 0xeb, 0x57}; > > diff --git a/examples/af_inet6_tx.c b/examples/af_inet6_tx.c > index 9fe7491..a62f730 100644 > --- a/examples/af_inet6_tx.c > +++ b/examples/af_inet6_tx.c > @@ -35,7 +35,7 @@ int main(int argc, char *argv[]) { > int ret, sd; > struct sockaddr_in6 dst; > struct ifreq ifr; > - unsigned char buf[MAX_PACKET_LEN + 1]; > + char buf[MAX_PACKET_LEN + 1]; > > /* Create IPv6 address family socket for the SOCK_DGRAM type */ > sd = socket(PF_INET6, SOCK_DGRAM, 0); > This patch has now been applied to wpan-tools. regards Stefan Schmidt