From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2879CC433F5 for ; Tue, 1 Feb 2022 20:51:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239848AbiBAUvI (ORCPT ); Tue, 1 Feb 2022 15:51:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiBAUvI (ORCPT ); Tue, 1 Feb 2022 15:51:08 -0500 Received: from proxima.lasnet.de (proxima.lasnet.de [IPv6:2a01:4f8:121:31eb:3::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF74C061714; Tue, 1 Feb 2022 12:51:08 -0800 (PST) Received: from [IPV6:2003:e9:d731:20df:8d81:5815:ac7:f110] (p200300e9d73120df8d8158150ac7f110.dip0.t-ipconnect.de [IPv6:2003:e9:d731:20df:8d81:5815:ac7:f110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id 54835C0438; Tue, 1 Feb 2022 21:51:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenfreihafen.org; s=2021; t=1643748664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3HDTHgdBGxYnR3NuSwzN7b6LwcRQTmdN3eI6HEnKCik=; b=Nv2jprboaB8eFB7abg3NG+97frSogVpFvWhAkIn3SxHgG9E2uaBA27m8VJR26L9kxxML1t 13YkPItXmYBV52SQ8PY0j7qFMg4U2Q/JJKNXRx6J4gkuqArqsLVvN7HkNK+Nv4Tr3Hh8IB factAh/S/eaTEnacEwqHxetF6ihatea0yoYkJUzZeTWuKtnr5PtnpNMTTwkXxH1zE3aECF KSr5MqOsM0TzD13Ivg540hcecb8yasn0SHQBA3x8dADgXoU8Q2NZCuXGuLhUOpd9ywi8QA 4C4FYmf/y4ayjXo6vbZSED/NlxRtHaap3FATlXvOgnWfHNsAuWzAgWWlB+0MOQ== Message-ID: Date: Tue, 1 Feb 2022 21:51:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH wpan-next v2 5/5] net: ieee802154: Drop duration settings when the core does it already Content-Language: en-US To: Miquel Raynal , Alexander Aring , linux-wpan@vger.kernel.org Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Michael Hennerich , Varka Bhadram , Xue Liu , Alan Ott References: <20220128110825.1120678-1-miquel.raynal@bootlin.com> <20220128110825.1120678-6-miquel.raynal@bootlin.com> <20220201184014.72b3d9a3@xps13> From: Stefan Schmidt In-Reply-To: <20220201184014.72b3d9a3@xps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org Hello. On 01.02.22 18:40, Miquel Raynal wrote: > Hi, > >> --- a/drivers/net/ieee802154/ca8210.c >> +++ b/drivers/net/ieee802154/ca8210.c >> @@ -2978,7 +2978,6 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw) >> ca8210_hw->phy->cca.mode = NL802154_CCA_ENERGY_CARRIER; >> ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND; >> ca8210_hw->phy->cca_ed_level = -9800; >> - ca8210_hw->phy->symbol_duration = 16 * NSEC_PER_USEC; >> ca8210_hw->phy->lifs_period = 40; >> ca8210_hw->phy->sifs_period = 12; > > I've missed that error ^^ > > This driver should be fixed first (that's probably a copy/paste of the > error from the other driver which did the same). > > As the rest of the series will depend on this fix (or conflict) we could > merge it through wpan-next anyway, if you don't mind, as it was there > since 2017 and these numbers had no real impact so far (I believe). Not sure I follow this logic. The fix you do is being removed in 4/4 of your v3 set again. So it would only be in place for these two in between commits. As you laid out above this has been in place since 2017 and the number have no real impact. Getting the fix in wpan-next to remove it again two patches later would not be needed here. If you would like to have this fixed for 5.16 and older stable kernels I could go ahead and apply it to wpan and let it trickle down into stable trees. We would have to deal with either a merge of net into net-next or with a merge conflicts when sending the pull request. Both can be done. But given the circumstances above I have no problem to drop this fix completely and have it fixed implicitly with the rest of the patchset. regards Stefan Schmidt