From: Ian Kent <raven@themaw.net>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
Dave Chinner <dchinner@redhat.com>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH v2 02/15] xfs: mount-api - add fs parameter description
Date: Wed, 18 Sep 2019 11:43:06 +0800 [thread overview]
Message-ID: <0a273cfda20c220a296636d62843a63ddb0736f3.camel@themaw.net> (raw)
In-Reply-To: <20190917121005.GA2868@bfoster>
On Tue, 2019-09-17 at 08:10 -0400, Brian Foster wrote:
> On Tue, Sep 17, 2019 at 11:13:20AM +0800, Ian Kent wrote:
> > On Tue, 2019-08-27 at 08:39 -0400, Brian Foster wrote:
> > > On Fri, Aug 23, 2019 at 08:59:27AM +0800, Ian Kent wrote:
> > > > The new mount-api uses an array of struct fs_parameter_spec for
> > > > parameter parsing, create this table populated with the xfs
> > > > mount
> > > > parameters.
> > > >
> > > > The new mount-api table definition is wider than the token
> > > > based
> > > > parameter table and interleaving the option description
> > > > comments
> > > > between each table line is much less readable than adding them
> > > > to
> > > > the end of each table entry. So add the option description
> > > > comment
> > > > to each entry line even though it causes quite a few of the
> > > > entries
> > > > to be longer than 80 characters.
> > > >
> > > > Signed-off-by: Ian Kent <raven@themaw.net>
> > > > ---
> > > > fs/xfs/xfs_super.c | 48
> > > > +++++++++++++++++++++++++++++++++++++++++++++---
> > > > 1 file changed, 45 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > > > index f9450235533c..74c88b92ce22 100644
> > > > --- a/fs/xfs/xfs_super.c
> > > > +++ b/fs/xfs/xfs_super.c
> > > > @@ -38,6 +38,8 @@
> > > >
> > > > #include <linux/magic.h>
> > > > #include <linux/parser.h>
> > > > +#include <linux/fs_context.h>
> > > > +#include <linux/fs_parser.h>
> > > >
> > > > static const struct super_operations xfs_super_operations;
> > > > struct bio_set xfs_ioend_bioset;
> > > > @@ -47,9 +49,6 @@ static struct kset *xfs_kset; /* top-
> > > > level xfs sysfs dir */
> > > > static struct xfs_kobj xfs_dbg_kobj; /* global debug sysfs
> > > > attrs */
> > > > #endif
> > > >
> > > > -/*
> > > > - * Table driven mount option parser.
> > > > - */
> > >
> > > Not sure why this is comment is removed here if the associated
> > > code
> > > is
> > > staying put in this patch..?
> > >
> > > > enum {
> > > > Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev,
> > > > Opt_biosize,
> > > > Opt_wsync, Opt_noalign, Opt_swalloc, Opt_sunit,
> > > > Opt_swidth,
> > > > Opt_nouuid,
> > > > @@ -109,6 +108,49 @@ static const match_table_t tokens = {
> > > > {Opt_err, NULL},
> > > > };
> > > >
> > > > +static const struct fs_parameter_spec xfs_param_specs[] = {
> > > > + fsparam_u32 ("logbufs", Opt_logbufs), /* number of XFS
> > > > log buffers */
> > > > + fsparam_string ("logbsize", Opt_logbsize), /* size of XFS
> > > > log
> > > > buffers */
> > > > + fsparam_string ("logdev", Opt_logdev), /* log device
> > > > */
> > > > + fsparam_string ("rtdev", Opt_rtdev), /* realtime I/O
> > > > device */
> > > > + fsparam_u32 ("biosize", Opt_biosize), /* log2 of
> > > > preferred buffered io size */
> > >
> > > Hmm.. it looks like the difference between numerical values as
> > > strings
> > > vs. numeric types is whether we support things like unit suffixes
> > > (i.e.
> > > "64k"). That said, Opt_biosize uses suffix_kstrtoint() similar to
> > > Opt_logbsize yet is defined here as a u32 (and Opt_allocsize
> > > falls
> > > into
> > > the same parsing code but is a string). Is that wrong or am I
> > > just
> > > missing something wrt to the type specifiers here?
> >
> > Right, the distinction appeared to be between those that use a
> > human
> > unit (like 64k etc.) and those that don't.
> >
> > Opt_biosize looked different in that it's described to be "log2 of
> > preferred buffered io size" so I don't think it can be given as a
> > human unit and that also appeared to be the case from the original
> > options table.
> >
> > Do I need to change this somehow?
> >
>
> I'm not sure. Can you respond to the question in my most recent
> reply[1]
> to this patch please?
>
> Brian
>
> [1] https://lore.kernel.org/linux-xfs/20190830115611.GA25927@bfoster/
I see, yes, they are different in the unchanged source.
It seems to me that the handling of these should be changed since
it looks like Opt_allocsize can have a human unit value while
Opt_biosize, given it's listed as a log2 value, it doesn't make
sense to call suffix_kstrtoint() on it.
Maybe that should be corrected as a pre-patch in the series or
forwarded separately ... although I can see how this has gone
unnoticed.
>
> > > Brian
> > >
> > > > + fsparam_flag ("wsync", Opt_wsync), /* safe-mode nfs
> > > > compatible mount */
> > > > + fsparam_flag ("noalign", Opt_noalign), /* turn off
> > > > stripe alignment */
> > > > + fsparam_flag ("swalloc", Opt_swalloc), /* turn on
> > > > stripe width allocation */
> > > > + fsparam_u32 ("sunit", Opt_sunit), /* data volume
> > > > stripe unit */
> > > > + fsparam_u32 ("swidth", Opt_swidth), /* data volume
> > > > stripe width */
> > > > + fsparam_flag ("nouuid", Opt_nouuid), /* ignore
> > > > filesystem UUID */
> > > > + fsparam_flag_no("grpid", Opt_grpid), /* group-ID
> > > > from
> > > > parent directory (or not) */
> > > > + fsparam_flag ("bsdgroups", Opt_bsdgroups), /* group-ID from
> > > > parent directory */
> > > > + fsparam_flag ("sysvgroups", Opt_sysvgroups),/* group-ID from
> > > > current process */
> > > > + fsparam_string ("allocsize", Opt_allocsize), /* preferred
> > > > allocation size */
> > > > + fsparam_flag ("norecovery", Opt_norecovery),/* don't run XFS
> > > > recovery */
> > > > + fsparam_flag ("inode64", Opt_inode64), /* inodes can be
> > > > allocated anywhere */
> > > > + fsparam_flag ("inode32", Opt_inode32), /* inode
> > > > allocation limited to XFS_MAXINUMBER_32 */
> > > > + fsparam_flag_no("ikeep", Opt_ikeep), /* do not free
> > > > (or
> > > > keep) empty inode clusters */
> > > > + fsparam_flag_no("largeio", Opt_largeio), /* report (or
> > > > do
> > > > not report) large I/O sizes in stat() */
> > > > + fsparam_flag_no("attr2", Opt_attr2), /* do (or do
> > > > not)
> > > > use attr2 attribute format */
> > > > + fsparam_flag ("filestreams",Opt_filestreams), /* use
> > > > filestreams allocator */
> > > > + fsparam_flag_no("quota", Opt_quota), /* disk quotas
> > > > (user) */
> > > > + fsparam_flag ("usrquota", Opt_usrquota), /* user quota
> > > > enabled */
> > > > + fsparam_flag ("grpquota", Opt_grpquota), /* group quota
> > > > enabled */
> > > > + fsparam_flag ("prjquota", Opt_prjquota), /* project quota
> > > > enabled */
> > > > + fsparam_flag ("uquota", Opt_uquota), /* user quota
> > > > (IRIX variant) */
> > > > + fsparam_flag ("gquota", Opt_gquota), /* group quota
> > > > (IRIX variant) */
> > > > + fsparam_flag ("pquota", Opt_pquota), /* project quota
> > > > (IRIX variant) */
> > > > + fsparam_flag ("uqnoenforce",Opt_uqnoenforce), /* user quota
> > > > limit enforcement */
> > > > + fsparam_flag ("gqnoenforce",Opt_gqnoenforce), /* group quota
> > > > limit enforcement */
> > > > + fsparam_flag ("pqnoenforce",Opt_pqnoenforce), /* project
> > > > quota limit enforcement */
> > > > + fsparam_flag ("qnoenforce", Opt_qnoenforce), /* same as
> > > > uqnoenforce */
> > > > + fsparam_flag_no("discard", Opt_discard), /* Do (or do
> > > > not)
> > > > not discard unused blocks */
> > > > + fsparam_flag ("dax", Opt_dax), /* Enable
> > > > direct access to bdev pages */
> > > > + {}
> > > > +};
> > > > +
> > > > +static const struct fs_parameter_description xfs_fs_parameters
> > > > = {
> > > > + .name = "XFS",
> > > > + .specs = xfs_param_specs,
> > > > +};
> > > >
> > > > STATIC int
> > > > suffix_kstrtoint(const substring_t *s, unsigned int base, int
> > > > *res)
> > > >
next prev parent reply other threads:[~2019-09-18 3:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 0:59 [PATCH v2 00/15] xfs: mount API patch series Ian Kent
2019-08-23 0:59 ` [PATCH v2 01/15] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-08-23 0:59 ` [PATCH v2 02/15] xfs: mount-api - add fs parameter description Ian Kent
2019-08-27 12:39 ` Brian Foster
2019-08-30 10:31 ` Ian Kent
2019-08-30 11:56 ` Brian Foster
2019-09-17 3:13 ` Ian Kent
2019-09-17 12:10 ` Brian Foster
2019-09-18 3:43 ` Ian Kent [this message]
2019-09-18 3:49 ` Ian Kent
2019-08-23 0:59 ` [PATCH v2 03/15] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-08-27 12:40 ` Brian Foster
2019-08-30 10:33 ` Ian Kent
2019-09-17 4:31 ` Ian Kent
2019-09-17 12:10 ` Brian Foster
2019-08-23 0:59 ` [PATCH v2 04/15] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-08-27 12:40 ` Brian Foster
2019-08-23 0:59 ` [PATCH v2 05/15] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-08-26 19:19 ` Eric Sandeen
2019-08-26 19:31 ` Eric Sandeen
2019-08-26 19:32 ` Eric Sandeen
2019-08-30 10:23 ` Ian Kent
2019-08-27 12:41 ` Brian Foster
2019-08-27 15:10 ` Darrick J. Wong
2019-08-27 15:15 ` Eric Sandeen
2019-08-28 0:55 ` Ian Kent
2019-08-30 10:51 ` Ian Kent
2019-08-23 0:59 ` [PATCH v2 06/15] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-08-27 12:41 ` Brian Foster
2019-08-30 10:55 ` Ian Kent
2019-08-23 0:59 ` [PATCH v2 07/15] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-08-27 12:42 ` Brian Foster
2019-08-30 10:56 ` Ian Kent
2019-08-23 0:59 ` [PATCH v2 08/15] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-08-28 13:27 ` Brian Foster
2019-08-30 11:01 ` Ian Kent
2019-08-23 1:00 ` [PATCH v2 09/15] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-08-28 13:27 ` Brian Foster
2019-08-23 1:00 ` [PATCH v2 10/15] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-08-28 13:27 ` Brian Foster
2019-08-23 1:00 ` [PATCH v2 11/15] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-08-28 13:28 ` Brian Foster
2019-08-30 11:10 ` Ian Kent
2019-08-30 11:56 ` Brian Foster
2019-09-02 2:41 ` Ian Kent
2019-08-23 1:00 ` [PATCH v2 12/15] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-08-28 13:28 ` Brian Foster
2019-08-30 11:19 ` Ian Kent
2019-08-30 11:20 ` Ian Kent
2019-08-23 1:00 ` [PATCH v2 13/15] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-08-28 13:28 ` Brian Foster
2019-08-23 1:00 ` [PATCH v2 14/15] xfs: mount-api - switch to new mount-api Ian Kent
2019-08-28 13:29 ` Brian Foster
2019-08-28 13:34 ` Eric Sandeen
2019-08-30 11:30 ` Ian Kent
2019-08-30 11:27 ` Ian Kent
2019-08-23 1:00 ` [PATCH v2 15/15] xfs: mount-api - remove legacy mount functions Ian Kent
2019-08-26 19:33 ` [PATCH v2 00/15] xfs: mount API patch series Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a273cfda20c220a296636d62843a63ddb0736f3.camel@themaw.net \
--to=raven@themaw.net \
--cc=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).