Re: [PATCH] xfs_io: Document '-q' option for sendfile command

[Eric Sandeen <sandeen@sandeen.net>]

On 7/21/20 10:15 PM, Xiao Yang wrote:
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  io/sendfile.c     | 3 ++-
>  man/man8/xfs_io.8 | 6 +++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/io/sendfile.c b/io/sendfile.c
> index ff012c81..a003bb55 100644
> --- a/io/sendfile.c
> +++ b/io/sendfile.c
> @@ -25,6 +25,7 @@ sendfile_help(void)
>  " Copies data between one file descriptor and another.  Because this copying\n"
>  " is done within the kernel, sendfile does not need to transfer data to and\n"
>  " from user space.\n"
> +" -q -- quiet mode, do not write anything to standard output.\n"
>  " -f -- specifies an input file from which to source data to write\n"
>  " -i -- specifies an input file name from which to source data to write.\n"
>  " An offset and length in the source file can be optionally specified.\n"
> @@ -168,7 +169,7 @@ sendfile_init(void)
>  	sendfile_cmd.argmax = -1;
>  	sendfile_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>  	sendfile_cmd.args =
> -		_("-i infile | -f N [off len]");
> +		_("[-q] -i infile | -f N [off len]");
>  	sendfile_cmd.oneline =
>  		_("Transfer data directly between file descriptors");
>  	sendfile_cmd.help = sendfile_help;
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index d3eb3e7e..caf3f15c 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -541,13 +541,17 @@ manual page to allocate and zero blocks within the range.
>  Truncates the current file at the given offset using
>  .BR ftruncate (2).
>  .TP
> -.BI "sendfile \-i " srcfile " | \-f " N " [ " "offset length " ]
> +.BI "sendfile [ \-q ] \-i " srcfile " | \-f " N " [ " "offset length " ]
>  On platforms which support it, allows a direct in-kernel copy between
>  two file descriptors. The current open file is the target, the source
>  must be specified as another open file
>  .RB ( \-f )
>  or by path
>  .RB ( \-i ).
> +.RS 1.0i
> +.B \-q
> +quiet mode, do not write anything to standard output.
> +.RE
>  .TP
>  .BI "readdir [ -v ] [ -o " offset " ] [ -l " length " ] "
>  Read a range of directory entries from a given offset of a directory.
>